OMTF emulator corresponding to the 2024 OMTF firmware [14_0_X] #44920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the OMTF algorithm that were introduced in the firmware after the previous OMTF emulator PR was merged. Mainly fixes related to the triggering on displaced muons. The firmware was deployed in the CMS on 19th March 2024. extrapolFactorsFilename added to the simOmtfDigis_cfi.py the simOmtfDigis_extrapolSimple_cfi.py is not needed now, so is deleted added L1Trigger/L1TMuonOverlapPhase2/python/fakeOmtfParamsPhase2_cff.py fix in GhostBusterPreferRefDt.cc customByRefLayer GhostBusterPreferRefDt::select - added a condition preventing eta overwriting in case the eta of the killed candidates is 121 OMTFProcessor<GoldenPatternType>::extrapolateDtPhiBFloatPoin and OMTFProcessor<GoldenPatternType>::extrapolateDtPhiBFixedPoint - extrFactor is now obtained from endcap stub r, and not eta. OmtfAngleConverter::getGlobalEta - stub r is now taken from the pure wire group, and not from the final_gp (global point) - matters for the extrapolation logic PatternGenerator::upadatePdfs() - deactivated (commented out) the process of code for setting the meanDistPhi to 0 if it is already small, as it seems it has no impact on the firmware occupancy PatternOptimizerBase: control histograms simMuEta and candEta OMTFProcessor<GoldenPatternType>::getFinalcandidatefix in setting hwPtw when ptAssignment is used in XDigiToStubsConverter::makeStubs, removed if (!dtPhDigis) return; if (!cscDigis) return; if (!rpcDigis) return; This is not needed as the DigiToStubsConverters are added dynamically to the vector digiToStubsConverters if given digis are configured to be used (parameter dropXXPrimitives is false in the config). But it was confusing: when the digi collection was not in the file, the job was still running without reporting the missing collection. PatternGenerator.cc - different DistPhiBitShift for phase-1 and phase-2 DataROOTDumper2.cc - rejecting events with more than one matchingResults (to clean the date for the NN training) cleanStubs - fasle, but filtering the matchingResults DataROOTDumper2.cc - dropping events with more than one matchingResults CandidateSimMuonMatcher.h - added method matchSimple() that matches simTracks and OMTF cands without propagation - it works well for the single muon samples. The problem with propagation is that it does not work for low pt muons (pt < ~3GeV). Added flag usePropagation to switch between matchSimple() and match() with propagation. - added phi folding for delta phi in ghostBust() (but it looks like it does not change the results) - in match() (version for the SimTrack), the MatchingResult is added also for the track for which the propagation failed. The changes should be still added to the match() version for the tracking particle. - fixed CandidateSimMuonMatcher::atStation2 - propagation to the RB1in culider bug fixes in StubResult and GoldenPatternResult, change finalise11() Omtf/AlgoMuon.h bug fix in AlgoMuon::getPatternNum() - checking if goldenPaternUnconstr, otherwise segmentation fault can be generated StubResult.h added method setPdfVal(), which is used in the GoldenPatternResult::finalise11() GoldenPatternResult.cc GoldenPatternResult::finalise11() - added penalty -63 for the phiB layers, if there was a hit but it does not fit the pdf operator<< - bug fix - checking if the pResult.omtfConfig is nullptr - this case occurs for the empty GoldenPatternResult L1Trigger/L1TMuonOverlapPhase1/test/expert/omtf/runMuonOverlap_PatsWithExtrapolation_efficiencyAnalyser.py - improved .py for running the emulator + analyzer Fixes in DataROOTDumper2 and CandidateSimMuonMatcher DataROOTDumper2 added flag usePropagation which if false turns on the filter on matchingResults.size() > 1 CandidateSimMuonMatcher::match() - threshold updated to be good for displaced muons in H2ll sample. There should be an automatic switch for this threshold added flags matchUsingPropagationInAnlyzer and matchUsingPropagationInDumper fixes of the candidate hwPt and HwPtUnconstrained Omtf/AlgoMuon.h - changed the value of getPtConstr and getPtUnconstr for an empty candidate from -1 to 0 (as it is in the interface note) OMTFConfiguration::etaBits2HwEta - added return 95 for bits == 0b111111111, as it is like that tin the FW OMTFProcessor<GoldenPatternType>::getFinalcandidates - hwPt is set to 1 if the constraint getPtConstr is 0 but getPtUnconstr > 0 L1Trigger/L1TMuonOverlapPhase1/src/Omtf/OMTFSorter.cc - bestGP is set to the golden pattern number 0 if getPdfSum() == 0 L1TMuonOverlapPhase1/src/Omtf/OMTFProcessor.cc - setting the output unconstrained pT to 1 when getPdfSumConstr. OMTFProcessor<GoldenPatternType>::getFinalcandidates - fixing the condition for the validity of the constrained pt XMLEventWriter.cc - removed constraints in the number of events that can be dumped to the xml
|
A new Pull Request was created by @mbluj for CMSSW_14_0_X. It involves the following packages:
@cmsbuild, @epalencia, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
Backport of #44893 |
|
please test |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Unit TestsI found 4 errors in the following unit tests: ---> test test_MC_23_setup had ERRORS ---> test test_MC_23_crosscheck had ERRORS ---> test test_MC_22_crosscheck had ERRORS and more ... RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn TestsExpand to see more addon errors ...
|
|
@aloeliger it should be tested with cms-data/L1Trigger-L1TMuon#26. This is already merged to cms-data, but not propagated to cms-distr of 14_0 (to be done). |
|
@mbluj Right, ok. I don't what the procedure is on data-file backports, but I could figure it out if you aren't already working on it. Let me know if you need assistance with that. |
As far as I remember in my PRs it has been always performed by release managers. Anyway, it requires that in https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_14_0_X/master/data/cmsswdata.txt L1Trigger-L1TMuon is updated to V01-10-00. I will check if I can do PR for it. |
|
Backport of update of OMTF data in cms-dist for 14_0 in cms-sw/cmsdist#9177. |
|
test parameters:
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c033e/39323/summary.html Comparison SummarySummary:
|
|
+l1 |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Changes to the OMTF algorithm which were introduced in the firmware for 2024: mainly changes related to the triggering on the displaced muons. With this update, the OMTF data-to-emulator agreement in the online DQM should be at the level of 99.5%. The firmware was deployed in the CMS on 19th March 2024.
This PR is backport of #43687 & #44893 and requires cms-data/L1Trigger-L1TMuon#26
FYI, @kbunkow
PR validation:
The version was checked by running the online DQM on the data from a collision run taken in April 2024 during testing the original PR to 14_1_X.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44893 on top of #43687 for 2024 operations. Requires cms-data/L1Trigger-L1TMuon#26 (added to cms-distr for 14_1, but not for 14_0).