-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ordering of egamma HLT modules in unseeded paths #44849
Fix ordering of egamma HLT modules in unseeded paths #44849
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44849/40100
|
A new Pull Request was created by @swagata87 for master. It involves the following packages:
@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
type egamma |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5847d1/39101/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is part II of #44592
In realistic phase2 menu, we only have L1 seeded egamma paths. So that was fixed (in #44592) as soon as the issue was spotted. However, the unseeded paths are also part of CMSSW so it's a good idea to not leave them with known issues. So, the unseeded paths' ordering is being fixed in this PR.
In Run2/Run3 it was common to use a mix of seeded and unseeded paths/legs. Specially, for multi-EG paths, it is rather common to use one seeded leg and keep others unseeded. Unseeded reco has higher efficiency, but also higher resource/timing cost. Depending on how CPU/GPU timing evolves for phase2 menu over next months/years, the same strategy (ie use both seeded and unseeded as necessary) can be done in phase2 HLT. So, the unseeded paths might become part of realistic menu some day, although now they are not.
PR validation:
Phase 2 HLT menu runs.