-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify trigger filterBits for electrons and photons in custom EGM Nano #44496
Conversation
cms-bot internal usage |
type egamma |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44496/39600 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44496/39600/cms-checkout-topic.log |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44496/39603
|
A new Pull Request was created by @RSalvatico for master. It involves the following packages:
@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d36d5f/38312/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR modifies the
filterBits
content for theTrigObj
s with id = 11 and id = 22 (electrons and photons, respectively) in the custom EGM Nano only, to better suit the current needs of the POG.PR validation:
Checked that we get credible results in terms of trigger objects, IDs and pT thresholds when requesting each of the filterBits to be on. One workflow that can be used is
runTheMatrix.py -l 2500.315 --sites ''