Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let tests fail gracefully if no devices are found #44036

Merged
merged 18 commits into from
Feb 23, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 20, 2024

PR description:

Let alpaka-based tests that require a device fail gracefully if there are no available devices on the given platform, instead of crashing or succeeding silently.

If more than one device is available, run the tests on each device.

PR validation:

Unit tests pass.

If there are no devices, the tests pass with an informational message instead of failing with a segmentation violation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@fwyzard fwyzard mentioned this pull request Feb 20, 2024
2 tasks
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

please test

@fwyzard fwyzard marked this pull request as draft February 20, 2024 23:42
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44036/38972

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • RecoTracker/PixelVertexFinding (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @missirol, @VinInn, @mtosi, @VourMa, @JanFSchulte, @rovere, @gpetruc, @felicepantaleo, @dgulhan, @mmusich this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f0ea5/37591/summary.html
COMMIT: 36bad59
CMSSW: CMSSW_14_1_X_2024-02-20-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44036/37591/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1065
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38675
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 21, 2024

enable gpu

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44036/38991

@cmsbuild
Copy link
Contributor

Pull request #44036 was updated. @fwyzard, @makortel, @cmsbuild, @mandrenguyen, @jfernan2 can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f0ea5/37613/summary.html
COMMIT: 8d4ec4a
CMSSW: CMSSW_14_1_X_2024-02-21-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44036/37613/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

There are some workflows for which there are errors in the baseline:
12434.402 step 2
12434.403 step 2
12434.404 step 2
12434.412 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39719
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@makortel
Copy link
Contributor

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2a41008 into cms-sw:master Feb 23, 2024
14 checks passed
@fwyzard fwyzard deleted the make_tests_fail_gracefully_141x branch March 2, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants