-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let tests fail gracefully if no devices are found #44036
Let tests fail gracefully if no devices are found #44036
Conversation
cms-bot internal usage |
enable gpu |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44036/38972
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f0ea5/37591/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
36bad59
to
8f8d706
Compare
enable gpu |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44036/38991
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f0ea5/37613/summary.html Comparison SummarySummary:
GPU Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Let alpaka-based tests that require a device fail gracefully if there are no available devices on the given platform, instead of crashing or succeeding silently.
If more than one device is available, run the tests on each device.
PR validation:
Unit tests pass.
If there are no devices, the tests pass with an informational message instead of failing with a segmentation violation.