Add Phase-2 Level-1 trigger ML MET emulator

[jmduarte]

PR description:

• Add ML-based MET to Phase-2 Level-1 trigger emulator
• Requires L1METML external integrated here: Add L1METML extra cmsdist#8901
• Presented at L1 Tau-Jets-MET meetings, e.g. https://indico.cern.ch/event/1081765/contributions/4549653
• This model represents a v1 baseline with post-training quantization. We expect to update it with a more realistic firmware implementation.
• Model and expected performance plots shown here: https://github.com/cms-hls4ml/L1METML/blob/main/README.md
• Currently enabled for testing; but plan to switch it off to run standard MET by default
• L1T Offline PR: Add Phase-2 Level-1 trigger ML MET emulator [14_0_0_pre3] cms-l1t-offline/cmssw#1193
• Model external repo: https://github.com/cms-hls4ml/L1METML

PR validation:

• Run on 40 (/RelValTTbar_14TeV/CMSSW_14_0_0_pre1-PU_133X_mcRun4_realistic_v1_2026D98PU200-v1/GEN-SIM-DIGI-RAW) events, and results are consistent with PUPPI MET (and ML algo)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43633/38287

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @jmduarte (Javier Duarte) for master.

It involves the following packages:

• L1Trigger/Phase2L1ParticleFlow (l1, upgrade)

@epalencia, @cmsbuild, @subirsarkar, @srimanob, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test with cms-sw/cmsdist#8901

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74e3d7/36663/summary.html
COMMIT: c3e317a
CMSSW: CMSSW_14_0_X_2023-12-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43633/36663/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw VecGeom: Update to version 1.2.7 cmsdist#8864
• @cms-sw [BuildRule] Unit test colored output cmsdist#8908

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74e3d7/36663/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74e3d7/36663/git-merge-result

Comparison Summary

Summary:

• You potentially removed 101 lines from the logs
• Reco comparison results: 2902 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1788
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 3245447
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[aloeliger]

@jmduarte on a slightly picky note I see you've added the model to the cms-hls4ml organization here: https://github.com/cms-hls4ml/L1METML, could you please add that into the description of the PR?

Has this emulator been discussed outside the L1 Tau-Jet-MET group?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43633/38411

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): Phase-2 TauMinator Tau (NNCaloTau) #42840, L1T Seeded Cone jets update #43233
  • File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): Phase-2 TauMinator Tau (NNCaloTau) #42840
  • File L1Trigger/Phase2L1ParticleFlow/BuildFile.xml modified in PR(s): TOoLLiP integration #43638

[jmduarte]

Sorry for the delay, all comments have now been addressed.

[aloeliger]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43633/39057

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): Adding Phase 2 HPS Tau Emulator #43848, Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872, Add emulated calo jets/taus to L1 sequence and event content. #44058
  • File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): Adding Phase 2 HPS Tau Emulator #43848, Add emulated calo jets/taus to L1 sequence and event content. #44058
  • File L1Trigger/Phase2L1ParticleFlow/BuildFile.xml modified in PR(s): TOoLLiP integration #43638

[cmsbuild]

Pull request #43633 was updated. @subirsarkar, @epalencia, @srimanob, @aloeliger can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74e3d7/37692/summary.html
COMMIT: 2926475
CMSSW: CMSSW_14_1_X_2024-02-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43633/37692/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 99 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 58 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 1189
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3244154
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[subirsarkar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1