-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DeepFlavour Jet tags to BTV DQM #42937
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42937/37083
|
A new Pull Request was created by @MaryShooshtari for master. It involves the following packages:
@mmusich, @mandrenguyen, @syuvivida, @tjavaid, @nothingface0, @jfernan2, @antoniovagnerini, @rvenditti, @cmsbuild, @Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -163,6 +163,7 @@ | |||
'keep *_hltParticleFlow_*_*', | |||
'keep *_hltParticleNetDiscriminatorsJetTagsAK8_*_*', | |||
'keep *_hltParticleNetDiscriminatorsJetTags_*_*', | |||
'keep *_hltPFDeepFlavour*_*_*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do NOT edit this file by hand.
To request updates open a CMS-HLT
JIRA ticket, clearly explaining why you need this
@MaryShooshtari please squash the commits so that the change in the |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42937/37104
|
Pull request #42937 was updated. @rvenditti, @antoniovagnerini, @cmsbuild, @tjavaid, @syuvivida, @mandrenguyen, @jfernan2, @nothingface0 can you please check and sign again. |
58e1a3f
to
18530ba
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42937/37108
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fd803/35064/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR aims to replace the outdated DeepCSV jet tags in Trigger DQM with the DeepFlavour algorithm, updating #42808.
Lastly, since we are trying to select events offline, we also added the DeepFlavour task to the RecoBTag sequence.
The expected changes are new btagging input plots in BTV HLT DQM.
This passes the basic tests suggested in CMSSW PR instructions.
12434.0 workflow runs without error and histograms are filled.
edit: further changes may be added, tbc