Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DeepFlavour Jet tags to BTV DQM #42937

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

MaryShooshtari
Copy link
Contributor

@MaryShooshtari MaryShooshtari commented Oct 3, 2023

This PR aims to replace the outdated DeepCSV jet tags in Trigger DQM with the DeepFlavour algorithm, updating #42808.

Lastly, since we are trying to select events offline, we also added the DeepFlavour task to the RecoBTag sequence.

The expected changes are new btagging input plots in BTV HLT DQM.

This passes the basic tests suggested in CMSSW PR instructions.
12434.0 workflow runs without error and histograms are filled.

edit: further changes may be added, tbc

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42937/37083

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

A new Pull Request was created by @MaryShooshtari for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTrigger/Configuration (hlt)
  • RecoBTag/Configuration (reconstruction)

@mmusich, @mandrenguyen, @syuvivida, @tjavaid, @nothingface0, @jfernan2, @antoniovagnerini, @rvenditti, @cmsbuild, @Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Senphy, @andrzejnovak, @JyothsnaKomaragiri, @cericeci, @HuguesBrun, @demuller, @AnnikaStein, @Fedespring, @Ming-Yan, @mtosi, @AlexDeMoor, @emilbols, @trocino, @rociovilar, @jhgoh, @silviodonato, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@@ -163,6 +163,7 @@
'keep *_hltParticleFlow_*_*',
'keep *_hltParticleNetDiscriminatorsJetTagsAK8_*_*',
'keep *_hltParticleNetDiscriminatorsJetTags_*_*',
'keep *_hltPFDeepFlavour*_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do NOT edit this file by hand.
To request updates open a CMS-HLT JIRA ticket, clearly explaining why you need this

@mmusich
Copy link
Contributor

mmusich commented Oct 3, 2023

@mmusich
Copy link
Contributor

mmusich commented Oct 5, 2023

@MaryShooshtari please squash the commits so that the change in the HLTrigger/Configuration is removed from the commit history. Thank you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42937/37104

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

Pull request #42937 was updated. @rvenditti, @antoniovagnerini, @cmsbuild, @tjavaid, @syuvivida, @mandrenguyen, @jfernan2, @nothingface0 can you please check and sign again.

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42937/37108

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fd803/35064/summary.html
COMMIT: 050ddc2
CMSSW: CMSSW_13_3_X_2023-10-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42937/35064/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 1022
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3355876
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 6, 2023

+1

@tjavaid
Copy link

tjavaid commented Oct 7, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants