Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate initializations in two DQM/HcalTasks plugins #38417

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Remove duplicate initializations in two DQM/HcalTasks plugins #38417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions DQM/HcalTasks/plugins/RecHitTask.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,6 @@ RecHitTask::RecHitTask(edm::ParameterSet const& ps)

// To fill histograms outside of the loop, you need to determine if there were
// any valid det ids first
uint32_t rawidValid = 0;
uint32_t rawidHBValid = 0;
uint32_t rawidHEValid = 0;

Expand Down Expand Up @@ -479,7 +478,6 @@ RecHitTask::RecHitTask(edm::ParameterSet const& ps)
//{meUnknownIds1LS->Fill(1); _unknownIdsPresent=true;continue;}

HcalElectronicsId const& eid(rawid);
rawidValid = did.rawId();
if (did.subdet() == HcalBarrel)
rawidHBValid = did.rawId();
else if (did.subdet() == HcalEndcap)
Expand Down Expand Up @@ -580,8 +578,9 @@ RecHitTask::RecHitTask(edm::ParameterSet const& ps)
// ^^^ONLINE ONLY!
}

// reset
rawidValid = 0;
// To fill histograms outside of the loop, you need to determine if there were
// any valid det ids first
uint32_t rawidValid = 0;

int nChsHO = 0;
int nChsHOCut = 0;
Expand Down
2 changes: 0 additions & 2 deletions DQM/HcalTasks/plugins/TPTask.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,8 +939,6 @@ TPTask::TPTask(edm::ParameterSet const& ps)

numHBHE = 0;
numHF = 0;
numCutHBHE = 0;
numCutHF = 0;
numMsnHBHE = 0;
numMsnHF = 0;
numCutHBHE = 0;
Expand Down