[12_3_X] Safeguard for nHits==0

[AdrianoDee]

PR description:

Backport to 12_3_X of #38159

Following discussion in #37933

[cmsbuild]

A new Pull Request was created by @AdrianoDee for CMSSW_12_3_X.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Safeguard for nHits==0 #38159

[AdrianoDee]

type trk

[AdrianoDee]

type bugfix

[AdrianoDee]

test parameters:

• enable_tests = gpu
• workflows_gpu = 11634.503, 11634.502, 39434.502
• workflows = 11634.501, 39434.501, 11634.502
• relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

[AdrianoDee]

please test

[perrotta]

@AdrianoDee could you please give a more descriptive title to the PR, for example the same of the backported one?

[AdrianoDee]

@AdrianoDee could you please give a more descriptive title to the PR, for example the same of the backported one?

Sure, moved to the original PR title

[AdrianoDee]

please test

[tvami]

backport of #38159

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1f444/25151/summary.html
COMMIT: 4675804
CMSSW: CMSSW_12_3_X_2022-05-31-2300/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38160/25151/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19864
• DQMHistoTests: Total failures: 1195
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 18669
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b1f444/39434.501_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3674966
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3674942
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 217 log files, 54 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[jpata]

Just to confirm: the validation picks up some fluctuations in pixel tracks.

This is not observed in this PR for 12_5 or 12_4. Is this an expected side-effect of this PR, or is it a random thing?

[missirol]

In my understanding, wf 11634.506 is known to produce at times non-reproducible outputs (tiny differences).

[AdrianoDee]

This is not observed in this PR for 12_5 or 12_4. Is this an expected side-effect of this PR, or is it a random thing?

Having inspected the changes I'd say that these are random differences, yes.

[silviodonato]

@qliphy @perrotta , please consider to include this PR in the next 12_3_X release which might avoid a crash in the HLT in runs without Pixels

[jpata]

+reconstruction

• backport of Safeguard for nHits==0 #38159
• technical bugfix

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1