Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sum of PS weights #38002

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

defranchis
Copy link
Contributor

PR description:

Seems like the sum of the PS weights was missing from the nanoAODs. This PR adds two branches to the "Run" tree, containing the missing information. The format is identical to that of other weights (e.g. scale, PDFs)

PR validation:

Run on MiniAOD sample TTToSemiLeptonic_TuneCP5_13TeV-powheg-pythia8 using CMSSW_10_6_27 (one version after the one used to produce NanoAODv9)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38002/30082

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @defranchis (Matteo Defranchis) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a382d/24836/summary.html
COMMIT: 22a6956
CMSSW: CMSSW_12_5_X_2022-05-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38002/24836/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3672375
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3672339
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

Screen Shot 2022-05-22 at 19 05 20

@mariadalfonso
Copy link
Contributor

+xpog
new set of weights added in the Run2 tree (see snapshot #38002 (comment))

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 23, 2022

+1

@cmsbuild cmsbuild merged commit 5e809e8 into cms-sw:master May 23, 2022
@defranchis
Copy link
Contributor Author

Thanks a lot! Is a backport necessary?

@mariadalfonso
Copy link
Contributor

Thanks a lot! Is a backport necessary?

indeed, better to have in 12_4 as well.

@defranchis
Copy link
Contributor Author

The backport of this PR is #38046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants