-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding sum of PS weights #38002
adding sum of PS weights #38002
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38002/30082
|
A new Pull Request was created by @defranchis (Matteo Defranchis) for master. It involves the following packages:
@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a382d/24836/summary.html Comparison SummarySummary:
|
+xpog |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Thanks a lot! Is a backport necessary? |
indeed, better to have in 12_4 as well. |
The backport of this PR is #38046 |
PR description:
Seems like the sum of the PS weights was missing from the nanoAODs. This PR adds two branches to the "Run" tree, containing the missing information. The format is identical to that of other weights (e.g. scale, PDFs)
PR validation:
Run on MiniAOD sample TTToSemiLeptonic_TuneCP5_13TeV-powheg-pythia8 using CMSSW_10_6_27 (one version after the one used to produce NanoAODv9)
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport