-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize TriggerHelper
and migrate to usage of DCSRecord
#37127
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37127/28655
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d361fc/22806/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Addresses comment #37084 (comment), by performing the same changes done in
GenericTriggerEventFlag
(to fall back to DCSRecord data provided by the software FED n. 1022, in case the DCS status from SCAL is not available) in PR #37084 also inTriggerHelper
class.PR validation:
cmssw
compiles, the class is not currently used anywhere else in cmssw, see: https://cmssdt.cern.ch/dxr/CMSSW/search?q=TriggerHelper&case=trueif this PR is a backport please specify the original PR and why you need to backport that PR:
N/A