-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable D88 PU wfs #36871
Disable D88 PU wfs #36871
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36871/28130
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1902b4/22177/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade This PR is to disable D88 PU workflows until the migration is complete. |
@cms-sw/pdmv-l2 do you agree in temporarily disabling the D88 PU wfs, thus avoiding the errors in the IB tests until minbias events for the PU can be produced in pre5? |
OK, so this would mean performing the D88 validation in noPU wfs in pre5 and, once D88 PU wfs are enabled in post-pre5 release, validate D88 once again (noPU and PU). This should be fine, unless @bbilin and @jordan-martins have a different opinion. |
Hi @kskovpen |
Or if needed, I can enable PU using 12_2_0_pre3 D88 for now, then update later. |
OK, let's follow this way. |
@cmsbuild please abort |
test parameters: |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1902b4/22253/summary.html Comparison SummarySummary:
|
+Upgrade |
I think the PR is ready as we agreed @kskovpen |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
This PR is to fix IB issue of D88 PU wfs, #36833 (comment)
In addition, this PR also disable D88 dd4hep wf, and update README.
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR: