Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X #36563

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_3_X. Includes the integration of the following JIRA tickets:

  • CMSHLT-2187: updates for Run-3 tracking, incl. CPU part of new heterogeneous pixel local reco, and pixel tracking+vertexing
  • CMSHLT-2206: addition of paths Status_OnCPU and Status_OnGPU
  • CMSHLT-2207: CPU part of heterogeneous ECAL local reco
  • CMSHLT-2208: CPU part of heterogeneous HCAL local reco

The PR also includes a syntax improvement suggested in #36536 (comment) (credits: @perrotta).

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36563/27507

  • This PR adds an extra 836KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@Martin-Grunewald
Copy link
Contributor

Why 'enable gpu' ?

@missirol
Copy link
Contributor Author

Why 'enable gpu' ?

To test the GRun menu in conjuction with the Patatrack customisation. In my understanding, that happens in wf 11634.506, which can be included with "enable gpu".

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89695a/21417/summary.html
COMMIT: a327ecf
CMSSW: CMSSW_12_3_X_2021-12-20-2300/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36563/21417/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19811
  • DQMHistoTests: Total failures: 2220
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17591
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461682
  • DQMHistoTests: Total failures: 37252
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3424408
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.102 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.017 KiB HLT/Filters
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: found differences in 6 / 42 workflows

@missirol
Copy link
Contributor Author

In my understanding, that happens in wf 11634.506, which can be included with "enable gpu".

Just to be more precise: as far as I know, the workflows included by "enable gpu" in the PR tests are listed here (11634.{506,512,522}), and in all 3 of them the GPU (Patatrack) customisation is applied to the HLT menu here via the gpu process modifier (e.g. from here).

@missirol
Copy link
Contributor Author

The outputs of the PR tests look okay, but I have to finish checking a few more things before signing.

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • There are several changes in trigger related DQM plots for Run3 wfs, vaidated by the HLT signature here

@cmsbuild cmsbuild merged commit 3f79e0f into cms-sw:master Dec 23, 2021
@missirol missirol deleted the HLTdevelopment123X branch December 24, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants