-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on compile issues with DMR, MTS and GC validation scripts. #35016
Conversation
@TomasKello, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35016/24867
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35016/24868
|
A new Pull Request was created by @TomasKello for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
@@ -33,7 +33,7 @@ | |||
## Load and Configure OfflineValidation and Output File | |||
## | |||
process.load("Alignment.OfflineValidation.TrackerOfflineValidation_.oO[offlineValidationMode]Oo._cff") | |||
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..compressionSettings = compressionSettings, | |||
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..compressionSettings = compressionSettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasKello please remove this, as it has already been taken care of by PR #34876
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35016/24871
|
33e3143
to
0b98ed0
Compare
Sorry for the mess... Resetting commits was much easier than trying to fix them. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35016/24876
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93b397/18036/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Introduces several fixes on tracker alignment validation scripts and macros which appeared to throw errors during compilation. Errors are mostly due to type conversion issues (TString <-> std::string) and broken forward declaration of imported classes and a few typos.
No changes in output are expected.
PR validation:
Changed macros were successfully tested during Alignment Validation on data and MC.