Migrate RecoTracker/CkfPattern, and ClusterShapeTrajectoryFilter to esConsumes

[makortel]

PR description:

Part of #31061. The EDModules CkfTrackCandidateMaker and CkfTrajectoryMaker are not currently reported by the "SA EventSetupRecord::get called" module list in IBs (the tool is being improved for that), so it is possible that I missed some helpers classes from other packages. I did migrate the ClusterShapeTrajectoryFilter that was pointed our by the IB list (for ConversionTrackCandidateProducer that is otherwise left for later).

Migration of TransientInitialStateEstimator had knock-on effects in RecoEgamma/EgammaPhotonAlgos and RecoEgamma/EgammaPhotonProducers.

PR validation:

Code compiles.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35000/24856

ERROR: Build errors found during clang-tidy run.

RecoPixelVertexing/PixelLowPtUtilities/src/ClusterShapeTrajectoryFilter.cc:45:22: error: no member named 'getData' in 'edm::Event' [clang-diagnostic-error]
  theCache = &iEvent.getData(theCacheToken);
                     ^
Suppressed 1103 warnings (1102 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35000/24860

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• RecoEgamma/EgammaPhotonAlgos (reconstruction)
• RecoEgamma/EgammaPhotonProducers (reconstruction)
• RecoPixelVertexing/PixelLowPtUtilities (reconstruction)
• RecoTracker/CkfPattern (reconstruction)
• RecoTracker/DebugTools (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@varuns23, @Sam-Harper, @felicepantaleo, @jainshilpi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @sobhatta, @ebrondol, @lecriste, @afiqaize, @gpetruc, @mmusich, @lgray, @mtosi, @dgulhan, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89ccad/18010/summary.html
COMMIT: 61a4ce9
CMSSW: CMSSW_12_1_X_2021-08-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35000/18010/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 6 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89ccad/18010/llvm-analysis/esrget-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35000 61a4ce9

• code changes are technical, in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1