Add support for the gpu modifier at HLT [12.0.x] #34979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_0_X. It involves the following packages:
@Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
|
please test |
fwyzard
changed the title
fwyzard
changed the title
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ce193/17965/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
fwyzard
force-pushed
the
HLT_customisation_for_GPU_120x
branch
from
66dce51 to
be76577
Compare
cmsbuild
added
pdmv-pending
tests-pending
upgrade-pending
and removed
tests-approved
labels
|
Pull request #34979 was updated. @cmsbuild, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @Martin-Grunewald, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
|
Rebased on top of CMSSW_12_0_0, and added support for running the HLT step on GPU in runTheMatrix. |
|
enable gpu |
|
please test |
|
-1 Failed Tests: RelVals RelVals-GPU RelVals-INPUT AddOn RelVals
Expand to see more relval errors ...RelVals-GPU
RelVals-INPUT
Expand to see more relval errors ...
AddOn Tests
Expand to see more addon errors ...
|
Simplify the Pixel local reconstruction running on GPU, taking advatage of cms-sw#34259.
fwyzard
force-pushed
the
HLT_customisation_for_GPU_120x
branch
from
0faf487 to
d98f14e
Compare
|
Pull request #34979 was updated. @cmsbuild, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @Martin-Grunewald, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ce193/18651/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
|
+1 |
|
+Upgrade |
|
@cms-sw/pdmv-l2 Any comment? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pending-signatures
pdmv-pending
labels
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
When the
gpumodifier is enabled, make the Pixel, ECAL and HCAL reconstruction running at HLT offloadable to a GPU.PR validation:
Tested with
cmsDriver.py reHLT \ --processName reHLT \ -s HLT:@relval2021 \ --conditions 120X_mcRun3_2021_realistic_v4 \ --datatier GEN-SIM-DIGI-RAW \ -n 10 \ --eventcontent FEVTDEBUGHLT \ --geometry DB:Extended \ --era Run3 \ --procModifiers gpu \ --filein /store/relval/CMSSW_12_0_0_pre6/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_120X_mcRun3_2021_realistic_v4_JIRA_129-v1/00000/79c06ed5-929b-4a57-a4f2-1ae90e6b38c5.rootWith this change, the
customizeHLTforPatatrack()customisation will be tested as part of the.502,.512and.522GPU workflows, andcustomizeHLTforPatatrackTriplets()with the.506workflow.if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport to 12.0.0 of #34978.