-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct labels for a Trigger plot in ECAL DQM #34953
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34953/24773
|
A new Pull Request was created by @abhih1 (Abhirami Harilal) for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-759430/17889/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR addresses a bug that was observed in the 2D trigger plot Real Vs Emulated Tp digis, where the x and y axis labels were swapped. This has been fixed.
PR validation:
The changes have been validated by running an offline ECAL DQM workflow on a 2018 run and uploading the output file to a test Gui. It now displays the correct labels.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A