Do not produce NaNs in SiPixelActionExecutor

[mmusich]

resolves #34890

PR description:

Title says is all.

PR validation:

Run wf 8.0 with runTheMatrix.py -l 8.0 -j 8 and inspected output DQM ROOT file.

averageDigiOccupancy	avgfedDigiOccvsLumi

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but it could be backported to all (?) production releases

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34900/24708

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiPixelMonitorDigi/src/SiPixelDigiSource.cc modified in PR(s): TkDQM: fix reset counter logic in SiPixelDigiSource #32875

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQM/SiPixelMonitorClient (dqm)
• DQM/SiPixelMonitorDigi (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d009db/17813/summary.html
COMMIT: a70edbc
CMSSW: CMSSW_12_1_X_2021-08-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34900/17813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000323
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

Thanks @mmusich !!

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[mmusich]

is there any interest for backports? @tvami

[tvami]

I don't insist, but maybe it would be nice to have in 12_0_X, there we still can have bugfix PRs. And also for 11_3_X if that's going to be used for the cosmics rereco.

[mmusich]

I don't insist, but maybe it would be nice to have in 12_0_X, there we still can have bugfix PRs. And also for 11_3_X if that's going to be used for the cosmics rereco.

all right, see #34936 and #34937