Clean unused dependencies from BuildFiles #34809

guitargeek · 2021-08-05T22:21:47Z

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #34544).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added for 12_1_0_pre1.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

cmsbuild · 2021-08-05T22:31:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34809/24534

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimG4CMS/HGCalTestBeam/plugins/BuildFile.xml modified in PR(s): Phase2-TB63Z Rearrange the header file and make first example for dd4hep (replacing #34752) #34791

cmsbuild · 2021-08-05T22:31:55Z

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Alignment/LaserAlignment (alca)
CommonTools/CandAlgos (reconstruction)
Configuration/Skimming (pdmv)
DQM/GEM (dqm)
IOMC/EventVertexGenerators (simulation)
L1Trigger/L1TGEM (l1)
PhysicsTools/HepMCCandAlgos (analysis)
SimG4CMS/Calo (simulation)
SimG4CMS/HGCalTestBeam (upgrade, simulation)
SimG4CMS/HcalTestBeam (simulation)
SimG4CMS/Muon (simulation)
SimG4CMS/ShowerLibraryProducer (simulation)
SimG4CMS/Tracker (simulation)
SimG4Core/Application (simulation)
SimGeneral/Debugging (simulation)

@andrius-k, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @AdrianoDee, @tlampen, @pohsun, @santocch, @cecilecaillol, @perrotta, @civanch, @yuanchao, @ErnestaP, @ahmad3213, @cmsbuild, @mdhildreth, @jfernan2, @kskovpen, @slava77, @jpata, @francescobrivio, @malbouis, @jordan-martins, @rekovic, @kmaeshima, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@adewit, @makortel, @cvuosalo, @jan-kaspar, @tocheng, @Martin-Grunewald, @bsunanda, @watson-ij, @thomreis, @felicepantaleo, @simonepigazzini, @mmusich, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-08-05T23:17:19Z

@cmsbuild , please test

cmsbuild · 2021-08-06T15:16:24Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffe4f9/17600/summary.html
COMMIT: a3765c0
CMSSW: CMSSW_12_1_X_2021-08-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34809/17600/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11606.011606.0_SingleMuPt1+2021+SingleMuPt1_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleMuPt1+2021+SingleMuPt1_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999410
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2999381
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

srimanob · 2021-08-06T15:19:06Z

@cmsbuild please test

Give it another try.

cmsbuild · 2021-08-06T21:40:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffe4f9/17615/summary.html
COMMIT: a3765c0
CMSSW: CMSSW_12_1_X_2021-08-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34809/17615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999410
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2999375
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

civanch · 2021-08-06T22:41:52Z

SimG4CMS/HGCalTestBeam/BuildFile.xml

 <use name="SimG4CMS/Calo"/>
 <use name="SimG4Core/Notification"/>
-<use name="SimG4Core/Watcher"/>


@bsunanda , do you agree with removal of these dependencies? I am sure they are not used now....

slava77 · 2021-08-07T00:46:46Z

+reconstruction

for #34809 a3765c0

code changes in reco are in CommonTools/CandAlgos/plugins/BuildFile.xml and appear to be correct
jenkins tests pass

civanch · 2021-08-08T12:56:12Z

+1

bbilin · 2021-08-09T05:09:13Z

+1

yuanchao · 2021-08-09T09:35:08Z

+1

clean unused depts. in buildfiles (technical)
matrix tests and unit tests passed

jfernan2 · 2021-08-10T07:43:56Z

+1

srimanob · 2021-08-12T13:24:24Z

+Upgrade

Technical PRs to clean unused dependencies.

qliphy · 2021-08-13T02:19:37Z

kindly ping @cms-sw/l1-l2

qliphy · 2021-08-16T01:47:34Z

+1

qliphy · 2021-08-16T01:48:42Z

merge

@cms-sw/l1-l2 Let's merge this technical PR first.

santocch · 2021-09-14T07:24:53Z

+1

Clean unused dependencies from BuildFiles

a3765c0

cmsbuild added this to the CMSSW_12_1_X milestone Aug 5, 2021

cmsbuild added alca-pending analysis-pending code-checks-pending dqm-pending l1-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Aug 5, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 5, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2021

cmsbuild mentioned this pull request Aug 6, 2021

Phase2-TB63Z Rearrange the header file and make first example for dd4hep (replacing #34752) #34791

Merged

cmsbuild added tests-rejected and removed tests-started labels Aug 6, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 6, 2021

cmsbuild removed the tests-started label Aug 6, 2021

civanch reviewed Aug 6, 2021

View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 7, 2021

cmsbuild added simulation-approved and removed simulation-pending labels Aug 8, 2021

cmsbuild added pdmv-approved and removed pdmv-pending labels Aug 9, 2021

cmsbuild added alca-approved and removed alca-pending labels Aug 9, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Aug 10, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels Aug 12, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 16, 2021

cmsbuild merged commit 7322d80 into cms-sw:master Aug 16, 2021

guitargeek deleted the deps_1 branch August 16, 2021 08:59

guitargeek mentioned this pull request Sep 9, 2021

Clean unused dependencies from BuildFiles #35215

Merged

cmsbuild added analysis-approved and removed analysis-pending labels Sep 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean unused dependencies from BuildFiles #34809

Clean unused dependencies from BuildFiles #34809

guitargeek commented Aug 5, 2021

cmsbuild commented Aug 5, 2021

cmsbuild commented Aug 5, 2021

tvami commented Aug 5, 2021

cmsbuild commented Aug 6, 2021

srimanob commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

civanch Aug 6, 2021 •

edited

Loading

slava77 commented Aug 7, 2021

civanch commented Aug 8, 2021

bbilin commented Aug 9, 2021

yuanchao commented Aug 9, 2021

jfernan2 commented Aug 10, 2021

srimanob commented Aug 12, 2021

qliphy commented Aug 13, 2021

qliphy commented Aug 16, 2021

qliphy commented Aug 16, 2021

santocch commented Sep 14, 2021

Clean unused dependencies from BuildFiles #34809

Clean unused dependencies from BuildFiles #34809

Conversation

guitargeek commented Aug 5, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 5, 2021

cmsbuild commented Aug 5, 2021

tvami commented Aug 5, 2021

cmsbuild commented Aug 6, 2021

RelVals-INPUT

Comparison Summary

srimanob commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

Comparison Summary

civanch Aug 6, 2021 • edited Loading

Choose a reason for hiding this comment

slava77 commented Aug 7, 2021

civanch commented Aug 8, 2021

bbilin commented Aug 9, 2021

yuanchao commented Aug 9, 2021

jfernan2 commented Aug 10, 2021

srimanob commented Aug 12, 2021

qliphy commented Aug 13, 2021

qliphy commented Aug 16, 2021

qliphy commented Aug 16, 2021

santocch commented Sep 14, 2021

civanch Aug 6, 2021 •

edited

Loading