-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing modifier: run2_nanoAOD_106Xv2 for MET significance #34096
Add missing modifier: run2_nanoAOD_106Xv2 for MET significance #34096
Conversation
A new Pull Request was created by @gouskos for CMSSW_10_6_X. It involves the following packages: RecoMET/METProducers @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
urgent (bug fix for nanov9) |
(run2_miniAOD_UL|run2_nanoAOD_106Xv1).toModify(METSignificanceParams_Data, useDeltaRforFootprint = True) | ||
from Configuration.Eras.Modifier_run2_nanoAOD_106Xv2_cff import run2_nanoAOD_106Xv2 | ||
(run2_miniAOD_UL|run2_nanoAOD_106Xv1|run2_nanoAOD_106Xv2).toModify(METSignificanceParams, useDeltaRforFootprint = True) | ||
(run2_miniAOD_UL|run2_nanoAOD_106Xv1|run2_nanoAOD_106Xv2).toModify(METSignificanceParams_Data, useDeltaRforFootprint = True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is any of this needed in the master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This are already the settings in the master branch.
We backported back then but pipelined only for the nanov8 (run2_nanoAOD_106Xv1), but now we had to set explicitly for the nanov9 run2_nanoAOD_106Xv2 as well. Ideally we should set this as default and then reset for the nanos before UL (while keeping not the default in mini)
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48bba3/15906/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Add missing modifier in 106X relevant for nanoAOD-v9 production.
This makes the MET covariance matrix and MET significance to be identical between 106Xv2 and master [120X] - as they should be
PR validation:
runTheMatrix.py -l 136.8523