Backport of fix for genJetAK8ID matching in fatJetMCTable

[laurenhay]

PR description:
Fixes issue where the GenJetAK8IDx matching did not match the corresponding GenJetAK8Table id's because of a difference in pT cut between the collections being referenced by the jet tables
https://hypernews.cern.ch/HyperNews/CMS/get/JetMET/2103.htm

PR validation:
Validated on file in question in 10_6_19_patch2.
We scanned the file in 10_6_19_patch2 before changes and got the same output Matej saw:

[lahay@cmsdev20 src]$ root -l root://cms-xrd-global.cern.ch//store/mc/RunIISummer19UL17NanoAODv2/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/NANOAODSIM/106X_mc2017_realistic_v8-v1/280000/1FA6BD39-B319-C143-92BC-13BC01AF4B89.root
root [0] 
Attaching file root://cms-xrd-global.cern.ch//store/mc/RunIISummer19UL17NanoAODv2/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/NANOAODSIM/106X_mc2017_realistic_v8-v1/280000/1FA6BD39-B319-C143-92BC-13BC01AF4B89.root as _file0...
(TFile *) 0x55a2cf0
root [1] Events->Scan("FatJet_genJetAK8Idx[0]:nGenJetAK8","FatJet_genJetAK8Idx[0]>nGenJetAK8 ")
************************************
*    Row   * FatJet_ge * nGenJetAK *
************************************
*      149 *         2 *         0 *
*      561 *         3 *         2 *
*     2134 *         2 *         1 *
*     2939 *         5 *         3 *
*     9582 *         3 *         0 *
*    11441 *         3 *         2 *
*    16619 *         3 *         2 *
*    17807 *         2 *         0 *
... 

After the change, I reproduced a subset of the events using this cmsDriver command:

cmsDriver.py --python_filename TOP-RunIISummer19UL17NanoAODv2-00091_1_cfg.py --eventcontent NANOAODSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier NANOAODSIM --fileout file:TOP-RunIISummer19UL17NanoAODv2-00091.root --conditions 106X_mc2017_realistic_v8 --step NANO --filein dbs:/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/RunIISummer19UL17MiniAOD-106X_mc2017_realistic_v6-v4/MINIAODSIM --era Run2_2017,run2_nanoAOD_106Xv1 --no_exec --mc -n 100

And the resulting output from scanning the file was:

[lahay@cmsdev20 src]$ root -l TOP-RunIISummer19UL17NanoAODv2-00091.root 
*** DISPLAY not set, setting it to lxplus734.cern.ch:0.0
root [0] 
Attaching file TOP-RunIISummer19UL17NanoAODv2-00091.root as _file0...
(TFile *) 0x344c970
root [1] Events->Scan("FatJet_genJetAK8Idx[0]:nGenJetAK8","FatJet_genJetAK8Idx[0]>nGenJetAK8 ")
************************************
*    Row   * FatJet_ge * nGenJetAK *
************************************
************************************
==> 0 selected entries
(long long) 0

if this PR is a backport please specify the original PR and why you need to backport that PR:
Original PR:
#33839
Backport requested for production

[cmsbuild]

A new Pull Request was created by @laurenhay for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[gouskos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd2f29/15689/summary.html
COMMIT: 4d05a1f
CMSSW: CMSSW_10_6_X_2021-06-06-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33990/15689/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215543
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215208
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

@laurenhay
the v8 production need to be protected i.e. you need to restore the old statement for the right modified, something like this should work

(run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel).toModify( fatJetMCTable.genJetAK8Idx = Var("?genJetFwdRef().backRef().isNonnull()?genJetFwdRef().backRef().key():-1", int, doc="index of matched gen AK8 jet")

[mariadalfonso]

urgent

(mark what is needed for the nanov9)

[cmsbuild]

Pull request #33990 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd2f29/15703/summary.html
COMMIT: fd7c263
CMSSW: CMSSW_10_6_X_2021-06-06-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33990/15703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215543
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215207
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

changes inline with master; extra change to protect nanov8

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1