Adding UL16 PUID and fixing QGL values in nanoAOD #33925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33925/23003
|
|
A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for master. It involves the following packages: PhysicsTools/NanoAOD @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
55 tasks
|
please test with #33857 |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsNanoAOD had ERRORS RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
|
|
test parameters: pull_request = cms-data/RecoJets-JetProducers#13 |
|
please test with #33857 |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsNanoAOD had ERRORS RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
|
|
Probably both PR need to be mentioned together with comma separated.
|
|
please test with #33857,cms-data/RecoJets-JetProducers#13 |
|
please test |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsNanoAOD had ERRORS RelVals
RelVals-INPUT
|
|
Hi @mariadalfonso I don't know if the next build is available for testing. |
|
test parameters: |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c88107/15590/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
Changes as spotted by the tests are: or jetID for UL16 the puID distribution now is much closer to what is supposed to be: see below the ul18 ztautau |
|
+xpog changes inline with the description |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
PR validation:
runTheMatrixandscram build code-formatwithout errors.FYI @camclean @singh-ramanpreet