Mass precision in NanoGen + NanoAod, fix customization functions (10_6_X) #33688

mseidel42 · 2021-05-11T08:38:02Z

PR description:

Backported from #33637

Mass precision in NanoGen was low -> increased to RECO precision, and allow for full precision
Increase mass precision for SUSY particles in NanoAod

Backported from #32431

Fix bugs in genparticle pruning functions in NanoGen

PR validation:

Ran NanoGen, checked Z mass distribution, precision looks sufficient for analysis now:

if this PR is a backport please specify the original PR and why you need to backport that PR:

#33637 #32431

@mariadalfonso @kdlong

cmsbuild · 2021-05-11T08:38:24Z

A new Pull Request was created by @mseidel42 (Markus Seidel) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

qliphy · 2021-05-11T09:26:29Z

please test workflow 546,547,548

cmsbuild · 2021-05-11T12:54:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7f98f/14988/summary.html
COMMIT: 9770344
CMSSW: CMSSW_10_6_X_2021-05-10-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33688/14988/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7f98f/546.0_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7f98f/547.0_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7f98f/548.0_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215556
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215220
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-05-11T13:22:26Z

PhysicsTools/NanoAOD/python/genparticles_cff.py

@@ -41,7 +41,7 @@
         pt  = Var("pt",  float, precision=8),
         phi = Var("phi", float,precision=8),
         eta  = Var("eta",  float,precision=8),
-         mass = Var("?!((abs(pdgId)>=1 && abs(pdgId)<=5) || (abs(pdgId)>=11 && abs(pdgId)<=16) || pdgId==21 || pdgId==111 || abs(pdgId)==211 || abs(pdgId)==421 || abs(pdgId)==411 || (pdgId==22 && mass<1))?mass:0", float,precision="?(abs(pdgId)==6 && statusFlags().isLastCopy())?20:8",doc="Mass stored for all particles with the exception of quarks (except top), leptons/neutrinos, photons with mass < 1 GeV, gluons, pi0(111), pi+(211), D0(421), and D+(411). For these particles, you can lookup the value from PDG."),
+         mass = Var("?!((abs(pdgId)>=1 && abs(pdgId)<=5) || (abs(pdgId)>=11 && abs(pdgId)<=16) || pdgId==21 || pdgId==111 || abs(pdgId)==211 || abs(pdgId)==421 || abs(pdgId)==411 || (pdgId==22 && mass<1))?mass:0", float,precision="?((abs(pdgId)==6 || abs(pdgId)>1000000) && statusFlags().isLastCopy())?20:8",doc="Mass stored for all particles with the exception of quarks (except top), leptons/neutrinos, photons with mass < 1 GeV, gluons, pi0(111), pi+(211), D0(421), and D+(411). For these particles, you can lookup the value from PDG."),


we need to protect the v8 production in 106X

add something like
(run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel).toModify(genParticleTable, variables.mass = ... old text ...)

cmsbuild · 2021-05-12T09:38:57Z

Pull request #33688 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

cmsbuild · 2021-05-12T10:51:31Z

Pull request #33688 was updated. @smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @gouskos, @fgolf, @mariadalfonso can you please check and sign again.

cmsbuild · 2021-05-12T12:06:00Z

Pull request #33688 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-05-12T12:08:19Z

please test

cmsbuild · 2021-05-12T15:22:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7f98f/15021/summary.html
COMMIT: 7105386
CMSSW: CMSSW_10_6_X_2021-05-12-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33688/15021/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215557
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215220
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-05-12T16:57:32Z

+xpog

update to nanoGEN + fix for the susy masses

cmsbuild · 2021-05-12T16:57:54Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-05-12T17:15:51Z

+1

cmsbuild added this to the CMSSW_10_6_X milestone May 11, 2021

cmsbuild added orp-pending pending-signatures tests-pending xpog-pending labels May 11, 2021

cmsbuild added tests-started and removed tests-pending labels May 11, 2021

mariadalfonso mentioned this pull request May 11, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

cmsbuild added tests-approved and removed tests-started labels May 11, 2021

mariadalfonso reviewed May 11, 2021

View reviewed changes

cmsbuild added tests-pending and removed tests-approved labels May 12, 2021

mseidel42 force-pushed the NanoGen_106 branch from 6665bd6 to 17309ae Compare May 12, 2021 10:51

cmsbuild added the core-pending label May 12, 2021

mseidel42 added 4 commits May 12, 2021 13:29

Fix NanoGen mass precision and pruning

e1d8a83

Backport cms-sw#32431

f8c228a

Increase mass precision for SUSY particles

89b0d05

Protect the v8 production in 106X

7105386

mseidel42 force-pushed the NanoGen_106 branch from 17309ae to 7105386 Compare May 12, 2021 12:05

cmsbuild removed the core-pending label May 12, 2021

cmsbuild added tests-started and removed tests-pending labels May 12, 2021

cmsbuild added tests-approved and removed tests-started labels May 12, 2021

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels May 12, 2021

cmsbuild added orp-approved and removed orp-pending labels May 12, 2021

cmsbuild merged commit 513f493 into cms-sw:CMSSW_10_6_X May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mass precision in NanoGen + NanoAod, fix customization functions (10_6_X) #33688

Mass precision in NanoGen + NanoAod, fix customization functions (10_6_X) #33688

mseidel42 commented May 11, 2021

cmsbuild commented May 11, 2021

qliphy commented May 11, 2021

cmsbuild commented May 11, 2021

mariadalfonso May 11, 2021

cmsbuild commented May 12, 2021

cmsbuild commented May 12, 2021

cmsbuild commented May 12, 2021

mariadalfonso commented May 12, 2021

cmsbuild commented May 12, 2021

mariadalfonso commented May 12, 2021

cmsbuild commented May 12, 2021

silviodonato commented May 12, 2021

Mass precision in NanoGen + NanoAod, fix customization functions (10_6_X) #33688

Mass precision in NanoGen + NanoAod, fix customization functions (10_6_X) #33688

Conversation

mseidel42 commented May 11, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 11, 2021

qliphy commented May 11, 2021

cmsbuild commented May 11, 2021

Comparison Summary

mariadalfonso May 11, 2021

Choose a reason for hiding this comment

cmsbuild commented May 12, 2021

cmsbuild commented May 12, 2021

cmsbuild commented May 12, 2021

mariadalfonso commented May 12, 2021

cmsbuild commented May 12, 2021

Comparison Summary

mariadalfonso commented May 12, 2021

cmsbuild commented May 12, 2021

silviodonato commented May 12, 2021