Change input collection for genVisTaus

[mbluj]

PR description:

As title says: input collection of genParticles used to build genVisTaus is changed from prunedGenParticles (miniAOD collection) to finalGenParticles (nanoAOD collection) to ensure consistency with other genParticle-based information stored in nanoAOD, in particular to make mother indices working properly.

Expected changes:

• indices of mother particles of genVisTaus are correctly set,
• marginal impact on produced genVisTaus - with the new setup there is ~4/10000 less genVisTaus than with previous setup which is acceptable (tested with DY sample).

This fixes issue cms-nanoAOD#486.

A backport to 106X for nanoAODv9 is foreseen.

PR validation:

Change tested with a custom workflow with DYJetsToLL sample from Summer20UL production.
Matrix tests (runTheMatrix.py -l limited -i all --ibeos) successful.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33522/22281

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/taus_cff.py modified in PR(s): Clean up tau related nanoAOD content #33513

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[mariadalfonso]

The change is deactivated for former nanoAOD eras to ensure backward compatibility.

This "no change policy" should be done for the backport,
but for master is better to apply this bug fix for all previous nano.

[mbluj]

The change is deactivated for former nanoAOD eras to ensure backward compatibility.

This "no change policy" should be done for the backport,
but for master is better to apply this bug fix for all previous nano.

Does it mean that I should remove the era depended "inactivation" at all? Correct?

[mbluj]

Hi,
"inactivation" of the changes for past eras was removed as requested in the recent comment; description of the PR updated accordingly.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33522/22287

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/taus_cff.py modified in PR(s): Clean up tau related nanoAOD content #33513

[cmsbuild]

Pull request #33522 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mbluj]

In last commit tauGenJets producers were cloned to avoid potential problems with modified definition of original producers which are used in other workflows.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33522/22300

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/taus_cff.py modified in PR(s): Clean up tau related nanoAOD content #33513

[cmsbuild]

Pull request #33522 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mbluj]

In last commit tauGenJets producers were cloned to avoid potential problems with modified definition of original producers which are used in other workflows.

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5506d/14594/summary.html
COMMIT: c255002
CMSSW: CMSSW_12_0_X_2021-04-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33522/14594/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1273 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877605
• DQMHistoTests: Total failures: 3673
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2873890
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.699 KiB( 37 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

(the use of finalGenParticles is now also consistent with the ele/muon/ph)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

comparison diff are due to change in input dataset file

[qliphy]

+1

[makortel]

This PR could have caused ProductNotFound failures in NANOGEN workflows, see #33578