Switch resolution from Gaussian sigma to stdev for Phase2 L1T tracks

[emacdonald16]

PR description:

Switched the track resolution plots to use standard deviation instead of Gaussian fit and sigma. This improves durability, in particular for cases where there are low statistics and poor fitting. This will change the resolution plots slightly, but will make it easier to spot problems or bugs. All other plots remain the same.

In addition, I cleaned up the code a tad, to make it more compact.

This is also a potential fix for Issue #31644

PR validation:

Checked before and after comparisons of the resolution plots to make sure the change was reasonable and as expected, on a ttbar+200PU sample.
Ran runTheMatrix for wf 23234.0
Ran code checks (scram build code-checks; scram build code-format)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33073/21385

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @emacdonald16 for master.

It involves the following packages:

Validation/SiOuterTrackerV

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @sroychow this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-739065/13294/summary.html
COMMIT: 56eef41
CMSSW: CMSSW_11_3_X_2021-03-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33073/13294/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-739065/34634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-739065/34834.999_TTbar_14TeV+2026D76PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

• No significant changes to the logs found
• Reco comparison results: 3001 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2849195
• DQMHistoTests: Total failures: 64911
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2784262
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files

[jfernan2]

@emacdonald16 apart from changes in the invoved Resolution MEs, I see changes in pTResVsEta MEs
Are these expected too?
E.g. https://tinyurl.com/ycesanzb
Thanks

[emacdonald16]

Yes, @jfernan2, these are expected. They are the pT resolution plots, and will change just from switching the definition of the resolution to be the standard deviation instead of a gaussian fit

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1