Add SV charge

[gouskos]

PR description:

Add the sum of the charge of the tracks associated to each SV.
Needed for BTV, Charm tagging calibration in the W+c channel.

PR validation:

Inspected output after running:
cmsDriver.py test_nanoTuples_mc2017 -n 10 --mc --eventcontent NANOAODSIM --datatier NANOAODSIM --conditions auto:phase1_2017_realistic --step NANO --nThreads 1 --era Run2_2017,run2_nanoAOD_106Xv1 --filein /store/mc/RunIISummer19UL17MiniAOD/TTToSemiLeptonic_TuneCP5CR2_13TeV-powheg-pythia8/MINIAODSIM/106X_mc2017_realistic_v6-v1/10000/466694A9-3806-624C-87A0-97C8379FAD23.root --fileout file:nano_mc2017.root --customise_commands "process.options.wantSummary = cms.untracked.bool(True)"

Increase on the nanoAOD size/evt and time/evt negligible.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32874/21103

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @gouskos for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[gouskos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48133a/12838/summary.html
COMMIT: b265b23
CMSSW: CMSSW_11_3_X_2021-02-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32874/12838/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2751765
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2751736
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.16 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1325.81,... ): 0.078 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48133a/12838/summary.html
COMMIT: b265b23
CMSSW: CMSSW_11_3_X_2021-02-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32874/12838/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2751765
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2751736
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.16 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1325.81,... ): 0.078 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[mariadalfonso]

are those include all needed ?

[gouskos]

removed the ones not needed

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32874/21167

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #32874 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[gouskos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48133a/12958/summary.html
COMMIT: fbfe260
CMSSW: CMSSW_11_3_X_2021-02-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32874/12958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2750958
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.156 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1325.81,... ): 0.078 KiB Physics/NanoAODDQM
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[mariadalfonso]

+xpog

SV charge added to all nano

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1