Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence compilation warnings for MahiGPU.cu #32501

Closed
wants to merge 1 commit into from
Closed

silence compilation warnings for MahiGPU.cu #32501

wants to merge 1 commit into from

Conversation

smuzaffar
Copy link
Contributor

This should silence the following compilation warnings

  DataFormats/CaloRecHit/interface/MultifitComputations.h:77: warning: ignoring #pragma unroll  [-Wunknown-pragmas]
    77 |       for (int i = 1; i < MatrixType1::stride; i++) {
      | 
  DataFormats/CaloRecHit/interface/MultifitComputations.h:203: warning: ignoring #pragma unroll  [-Wunknown-pragmas]
   203 |       for (int icol = 0; icol < NPULSES; icol++) {

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32501/20429

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

RecoLocalCalo/HcalRecProducers

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@apsallid, @mariadalfonso, @abdoulline this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cba43d/11733/summary.html
CMSSW: CMSSW_11_3_X_2020-12-15-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747284
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2747261
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@perrotta
Copy link
Contributor

@smuzaffar : I think that the same silencing aimed at in this PR is also obtained with #32499, recently submitted by @fwyzard, without having to ignore the warning.
Does everybody agree closing this one in favor of #32499?

@smuzaffar
Copy link
Contributor Author

closing in favor of #32499

@smuzaffar smuzaffar closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants