NanoAOD: backport to 10_6_X branch of muon pT > 15 GeV passthrough, addition of isotrack charge and muon isStandalone flag. #32107

mdunser · 2020-11-11T14:51:37Z

PR description:

backport to 10_6_X branch of muon pT > 15 GeV passthrough, regardless of ID

this is the backport of PR #32103
additional backports of #33208 and #33212

cmsbuild · 2020-11-11T14:52:04Z

A new Pull Request was created by @mdunser for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from NanoAOD: pass through for muon and Isotrack above 15 GeV in pt, regardless of ID or dxy/dz #32103

mariadalfonso · 2020-11-11T15:14:42Z

please test

cmsbuild · 2020-11-11T15:15:06Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-11-11-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10651/console Started: 2020/11/11 16:16

cmsbuild · 2020-11-11T16:32:47Z

+1
Tested at: b5f2966
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b2788/10651/summary.html
CMSSW: CMSSW_10_6_X_2020-11-11-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-11-11T16:32:49Z

Comparison job queued.

cmsbuild · 2020-11-11T18:21:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b2788/10651/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 71 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214708
DQMHistoTests: Total failures: 115
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214259
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 14 edm output root files, 34 DQM output files

silviodonato · 2020-11-16T11:26:24Z

backport of #32103

mariadalfonso · 2021-03-29T11:35:08Z

@mdunser

please update this backport based on the review in master,
note that we need to safeguard the current ongoing v8 production in 10_6_X
(run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel).toModify(xyzTable , xyxVariable = None)

mariadalfonso · 2021-04-20T08:08:54Z

please test

cmsbuild · 2021-04-20T10:02:34Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b2788/14343/summary.html
COMMIT: 3f0509b
CMSSW: CMSSW_10_6_X_2021-04-19-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32107/14343/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

RelVals-INPUT

136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log
136.7721136.7721_RunJetHT2016H_reminiaod+RunJetHT2016H_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016/step2_RunJetHT2016H_reminiaod+RunJetHT2016H_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016.log
136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log

Expand to see more relval errors ...

mariadalfonso · 2021-04-20T11:19:51Z

@mdunser @sroychow
please have a look

File "/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32107/14343/CMSSW_10_6_X_2021-04-19-2300/python/DQMOffline/Configuration/DQMOffline_cff.py", line 190, in <module>
   from PhysicsTools.NanoAOD.nanoDQM_cff import nanoDQM
 File "/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32107/14343/CMSSW_10_6_X_2021-04-19-2300/python/PhysicsTools/NanoAOD/nanoDQM_cff.py", line 83, in <module>
   _Isotk_nocharge = [plot for plot in nanoDQM.vplots.IsoTrack.plots if plot.name.value() != 'charge']
AttributeError: 'PSet' object has no attribute 'IsoTrack'

gouskos · 2021-04-20T11:37:34Z

@mdunser @sroychow
please have a look

File "/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32107/14343/CMSSW_10_6_X_2021-04-19-2300/python/DQMOffline/Configuration/DQMOffline_cff.py", line 190, in <module>
   from PhysicsTools.NanoAOD.nanoDQM_cff import nanoDQM
 File "/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32107/14343/CMSSW_10_6_X_2021-04-19-2300/python/PhysicsTools/NanoAOD/nanoDQM_cff.py", line 83, in <module>
   _Isotk_nocharge = [plot for plot in nanoDQM.vplots.IsoTrack.plots if plot.name.value() != 'charge']
AttributeError: 'PSet' object has no attribute 'IsoTrack'

You should do something like here:
https://github.com/cms-sw/cmssw/blob/3f0509b3f96b114c99735f836ee8e1e79728d6f3/PhysicsTools/NanoAOD/python/nanoDQM_cff.py#L70-78

sroychow · 2021-04-22T16:45:22Z

Hi @gouskos the lines added for the Isotrack should work in principle since it does the same thing done in line 71 - 75. The problem in my opinion comes from line 67 since for run2_miniAOD_80XLegacy, the IsoTrack Pset is removed. The simplest solution is to move line 67 to the end of the file(this works in the local tests I did).

cmsbuild · 2021-04-23T09:18:53Z

Pull request #32107 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-04-23T11:00:17Z

please test

cmsbuild · 2021-04-23T13:54:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b2788/14539/summary.html
COMMIT: eabe843
CMSSW: CMSSW_10_6_X_2021-04-23-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32107/14539/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 158 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215541
DQMHistoTests: Total failures: 76
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215131
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.329 KiB( 34 files compared)
DQMHistoSizes: changed ( 136.8523 ): 0.329 KiB Physics/NanoAODDQM
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-04-27T19:41:25Z

+xpog

changes inline with master (3PRs backport)
106Xv1 unchanged

cmsbuild · 2021-04-27T19:41:51Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-04-28T01:40:31Z

+1

cmsbuild added this to the CMSSW_10_6_X milestone Nov 11, 2020

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures tests-pending xpog-pending labels Nov 11, 2020

mdunser mentioned this pull request Nov 11, 2020

NanoAOD: pass through for muon and Isotrack above 15 GeV in pt, regardless of ID or dxy/dz #32103

Merged

mariadalfonso mentioned this pull request Nov 11, 2020

features for V8 nanoAOD cms-nanoAOD/cmssw#533

Closed

55 tasks

cmsbuild added tests-started and removed tests-pending labels Nov 11, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 11, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 11, 2020

cmsbuild added the backport label Nov 16, 2020

silviodonato marked this pull request as draft November 16, 2020 16:40

mariadalfonso mentioned this pull request Nov 17, 2020

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

cmsbuild mentioned this pull request Dec 20, 2020

Nano modifiers106 #32564

Merged

cmsbuild added backport-ok and removed backport labels Mar 25, 2021

cmsbuild removed the analysis-pending label Mar 29, 2021

cmsbuild added the tests-rejected label Apr 16, 2021

cmsbuild added tests-started and removed tests-rejected labels Apr 20, 2021

cmsbuild added tests-rejected and removed tests-started labels Apr 20, 2021

moving a line further down to hopefully fix a bug

eabe843

cmsbuild added tests-pending and removed tests-rejected labels Apr 23, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 23, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 23, 2021

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Apr 27, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 28, 2021

cmsbuild merged commit 15e312a into cms-sw:CMSSW_10_6_X Apr 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NanoAOD: backport to 10_6_X branch of muon pT > 15 GeV passthrough, addition of isotrack charge and muon isStandalone flag. #32107

NanoAOD: backport to 10_6_X branch of muon pT > 15 GeV passthrough, addition of isotrack charge and muon isStandalone flag. #32107

mdunser commented Nov 11, 2020 •

edited

Loading

cmsbuild commented Nov 11, 2020 •

edited

Loading

mariadalfonso commented Nov 11, 2020

cmsbuild commented Nov 11, 2020 •

edited

Loading

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

silviodonato commented Nov 16, 2020

mariadalfonso commented Mar 29, 2021

mariadalfonso commented Apr 20, 2021

cmsbuild commented Apr 20, 2021

mariadalfonso commented Apr 20, 2021

gouskos commented Apr 20, 2021 •

edited

Loading

sroychow commented Apr 22, 2021

cmsbuild commented Apr 23, 2021

mariadalfonso commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

mariadalfonso commented Apr 27, 2021

cmsbuild commented Apr 27, 2021

qliphy commented Apr 28, 2021

NanoAOD: backport to 10_6_X branch of muon pT > 15 GeV passthrough, addition of isotrack charge and muon isStandalone flag. #32107

NanoAOD: backport to 10_6_X branch of muon pT > 15 GeV passthrough, addition of isotrack charge and muon isStandalone flag. #32107

Conversation

mdunser commented Nov 11, 2020 • edited Loading

PR description:

cmsbuild commented Nov 11, 2020 • edited Loading

mariadalfonso commented Nov 11, 2020

cmsbuild commented Nov 11, 2020 • edited Loading

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

silviodonato commented Nov 16, 2020

mariadalfonso commented Mar 29, 2021

mariadalfonso commented Apr 20, 2021

cmsbuild commented Apr 20, 2021

RelVals

RelVals-INPUT

mariadalfonso commented Apr 20, 2021

gouskos commented Apr 20, 2021 • edited Loading

sroychow commented Apr 22, 2021

cmsbuild commented Apr 23, 2021

mariadalfonso commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

Comparison Summary

mariadalfonso commented Apr 27, 2021

cmsbuild commented Apr 27, 2021

qliphy commented Apr 28, 2021

mdunser commented Nov 11, 2020 •

edited

Loading

cmsbuild commented Nov 11, 2020 •

edited

Loading

cmsbuild commented Nov 11, 2020 •

edited

Loading

gouskos commented Apr 20, 2021 •

edited

Loading