-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mkFit customization in initialStep with a Modifier #28755
Conversation
The customize function turned out to be fragile.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28755/13394
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Configuration/ProcessModifiers @perrotta, @pgunnell, @chayanit, @zhenhu, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@cmsbuild, please abort |
The tests are being triggered in jenkins. |
@cmsbuild, please abort |
Jenkins tests are aborted. |
@cmsbuild, please test workflow 11634.7 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+operations |
+1
|
+1 |
+1 |
merge |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
As found in #28678 (comment) the customize function turned out to be too fragile.
PR validation:
Workflow 11634.7 runs.