DQM: Reduce TH1 Usage #28342

schneiml · 2019-11-04T12:01:12Z

PR description:

This PR includes a few cherry-picks from the "new DQMStore" branch that remove unnecessary calls to getTH1 and friends. While there is no specific reason to do this now, getTH1 is unsafe in general and will become illegal at some point (for certain situations, at least).

For now, this is just general cleanup of the DQM codebase.

Some new APIs in the MonitorElement are required for this, since those are present in #28092, it is included here. This PR should wait until #28092 is merged.

I excluded the changes regarding SetCanExtend, since I am not really sure if and where it is safe to remove these calls. This will need to be figured out later.

PR validation:

No changes expected.

cmsbuild · 2019-11-04T12:01:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-11-04T12:09:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28342/12609

This PR adds an extra 696KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CalibTracker/SiStripChannelGain/interface/APVGainHelpers.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File CalibTracker/SiStripChannelGain/interface/SiStripGainsPCLWorker.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File CalibTracker/SiStripChannelGain/src/SiStripGainsPCLWorker.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/BeamMonitor/plugins/BeamConditionsMonitor.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/BeamMonitor/plugins/BeamConditionsMonitor.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/BeamMonitor/python/BeamConditionsMonitor_cff.py modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/EcalPreshowerMonitorModule/src/ESIntegrityTask.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Remove more DQMStore features #28247
- File DQM/HLTEvF/plugins/DaqTestHistograms.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/LumiMonitor.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/PSMonitor.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/TrigObjTnPHistColl.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/TrigObjTnPHistColl.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/TrigObjTnPSource.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/TriggerBxMonitor.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/TriggerBxVsOrbitMonitor.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HLTEvF/plugins/TriggerRatesMonitor.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/HcalTasks/plugins/ZDCTask.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/RPCMonitorDigi/interface/utils.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/SiPixelMonitorRawData/interface/SiPixelRawDataErrorModule.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQM/SiStripMonitorTrack/src/SiStripMonitorTrack.cc modified in PR(s): Strip Clusterizer from Zero Suppressed Readout #28304
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): DQM: Remove more DQMStore features #28247, Introduce changes in order to switch from LumiScalers to MetaData #27677
- File DQM/TrackingMonitorClient/plugins/TrackingDQMClientHeavyIons.cc modified in PR(s): DQM: Restructure QTests #28316
- File DQMOffline/EGamma/src/ElectronDqmHarvesterBase.cc modified in PR(s): DQM: Remove more DQMStore features #28247
- File DQMOffline/JetMET/src/JetAnalyzer.cc modified in PR(s): AOD changes from JME #28077
- File DQMOffline/L1Trigger/interface/L1TFillWithinLimits.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQMOffline/PFTau/plugins/PFClient.cc modified in PR(s): DQM: Remove more DQMStore features #28247
- File DQMOffline/Trigger/src/HLTTauDQMPathPlotter.cc modified in PR(s): HLTTauDQM: moved some warnings behind a verbose flag #28091
- File DQMServices/Core/interface/ConcurrentMonitorElement.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQMServices/Core/interface/DQMGlobalEDAnalyzer.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQMServices/Core/interface/DQMStore.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Restructure QTests #28316, DQM: Remove more DQMStore features #28247
- File DQMServices/Core/interface/MonitorElement.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Restructure QTests #28316, DQM: Remove more DQMStore features #28247
- File DQMServices/Core/interface/QReport.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Restructure QTests #28316
- File DQMServices/Core/interface/QTest.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Restructure QTests #28316
- File DQMServices/Core/src/DQMService.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQMServices/Core/src/DQMStore.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Restructure QTests #28316, DQM: Remove more DQMStore features #28247
- File DQMServices/Core/src/MonitorElement.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Restructure QTests #28316, DQM: Remove more DQMStore features #28247
- File DQMServices/Core/test/BuildFile.xml modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092, DQM: Remove more DQMStore features #28247
- File DQMServices/Core/test/DQMFastMatchTest.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQMServices/Core/test/DQMTestMultiThread.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DQMServices/Core/test/DQMTestStandaloneBuildOfDQMStore.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DataFormats/Histograms/interface/MonitorElementCollection.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DataFormats/Histograms/src/classes.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File DataFormats/Histograms/src/classes_def.xml modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File HLTrigger/Timer/plugins/FastTimerService.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File HLTrigger/Timer/plugins/FastTimerService.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File HLTrigger/Timer/plugins/ThroughputService.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File HLTrigger/Timer/plugins/ThroughputService.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File HLTriggerOffline/SUSYBSM/src/SUSY_HLT_SingleLepton.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTRecHitQuality.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTRecHitQuality.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTSegment2DQuality.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTSegment2DQuality.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTSegment2DSLPhiQuality.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTSegment2DSLPhiQuality.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTSegment4DQuality.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/DTSegment4DQuality.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/DTRecHits/plugins/Histograms.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/HGCalValidation/plugins/CaloParticleValidation.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/HGCalValidation/plugins/TICLPFValidation.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/RecoTrack/interface/MTVHistoProducerAlgoForTracker.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/RecoTrack/interface/MultiTrackValidator.h modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/RecoTrack/plugins/MultiTrackValidator.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092
- File Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc modified in PR(s): DQM: Merge MonitorElement and ConcurrentMonitorElement #28092

cmsbuild · 2019-11-04T12:10:09Z

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

CalibTracker/SiStripChannelGain
Calibration/HcalCalibAlgos
DQM/BeamMonitor
DQM/CTPPS
DQM/CastorMonitor
DQM/EcalPreshowerMonitorModule
DQM/HLTEvF
DQM/HcalTasks
DQM/L1TMonitor
DQM/L1TMonitorClient
DQM/Physics
DQM/RPCMonitorClient
DQM/RPCMonitorDigi
DQM/SiPixelMonitorRawData
DQM/SiStripCommon
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorTrack
DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQMOffline/EGamma
DQMOffline/JetMET
DQMOffline/L1Trigger
DQMOffline/PFTau
DQMOffline/RecoB
DQMOffline/Trigger
DQMServices/Core
DataFormats/Histograms
HLTrigger/Timer
HLTriggerOffline/SUSYBSM
Validation/DTRecHits
Validation/HGCalValidation
Validation/HcalDigis
Validation/HcalHits
Validation/RecoB
Validation/RecoTrack
Validation/SiOuterTrackerV

@smuzaffar, @benkrikler, @Dr15Jones, @kmaeshima, @schneiml, @fwyzard, @christopheralanwest, @andrius-k, @tocheng, @Martin-Grunewald, @rekovic, @franzoni, @jfernan2, @cmsbuild, @fioriNTU, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@wmtford, @erikbutz, @rappoccio, @apsallid, @echabert, @felicepantaleo, @forthommel, @jandrea, @robervalwalsh, @emilbols, @kpedro88, @argiro, @HeinerTholen, @bsunanda, @pfs, @ahinzmann, @threus, @mmusich, @seemasharmafnal, @acimmino, @mmarionncern, @kreczko, @sethzenz, @JyothsnaKomaragiri, @makortel, @smoortga, @acaudron, @mverzett, @jhgoh, @lgray, @jdolen, @HuguesBrun, @cericeci, @ferencek, @battibass, @trocino, @rociovilar, @vandreev11, @pieterdavid, @barvic, @DryRun, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @missirol, @nhanvtran, @gkasieczka, @tocheng, @deguio, @schoef, @alesaggio, @idebruyn, @ebrondol, @mtosi, @dgulhan, @clelange, @jdamgov, @hdelanno, @jan-kaspar, @gbenelli, @Fedespring, @calderona, @hatakeyamak, @Martin-Grunewald, @mariadalfonso, @pvmulder, @andrzejnovak, @folguera, @fioriNTU this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

tlampen · 2019-11-05T14:16:03Z

please test

cmsbuild · 2019-11-05T14:16:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3352/console Started: 2019/11/05 15:21

cmsbuild · 2019-11-05T17:48:24Z

+1
Tested at: ec64cae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c9dbc/3352/summary.html

cmsbuild · 2019-11-05T17:48:28Z

Comparison job queued.

cmsbuild · 2019-11-05T19:35:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c9dbc/3352/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2939026
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2938684
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

Commands used: sed 's/->getTH....->Sumw2(/->enableSumw2(/g' -i $(ag -l -- "->getTH....->Sumw2") sed 's/->getTH....->SetOption(/->setOption(/g' -i $(ag -l -- "->getTH....->SetOption") sed 's/->getTH....->GetXaxis..->SetBinLabel(/->setBinLabel(/g' -i $(ag -l -- "->getTH....->GetXaxis..->SetBinLabel") sed 's/->getTH....->GetXaxis..->SetTitle(/->setAxisTitle(/g' -i $(ag -l -- "->getTH....->GetXaxis..->SetTitle") sed 's/->getTH....->SetBinContent(/->setBinContent(/g' -i $(ag -l -- "->getTH....->SetBinContent") sed 's/->getTH....->SetXTitle(/->setAxisTitle(/g' -i $(ag -l -- "->getTH....->SetXTitle") This does not cover Y axis things, since the axis number would need to be added manually for setAxisTitle/setBinLabel/etc. These files where excluded due to their usage of TString (which is not accepted by the ME API): Validation/RPCRecHits/src/RPCValidHistograms.cc Validation/RPCRecHits/src/RPCRecHitValid.cc DQMOffline/RecoB/src/EffPurFromHistos.cc

cmsbuild · 2019-11-19T16:48:19Z

-1

Tested at: ff441c2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c9dbc/3532/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

7.3 step1

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step1_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

158.0 step1

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step1_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_TTbar+TTbarFS+HARVESTFS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10024.0 step1

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10042.0 step1

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step1_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10224.0 step1

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

10824.0 step1

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

11634.0 step1

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

12434.0 step1

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

20434.0 step1

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

20034.0 step1

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

22034.0 step1

runTheMatrix-results/22034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D46_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D46+RecoFullGlobal_2026D46+HARVESTFullGlobal_2026D46/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D46_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D46+RecoFullGlobal_2026D46+HARVESTFullGlobal_2026D46.log

21234.0 step1

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

250202.181 step1

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step1_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Tue Nov 19 17:35:15 2019-date Tue Nov 19 17:33:37 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Tue Nov 19 17:35:20 2019-date Tue Nov 19 17:33:45 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:35:20 2019-date Tue Nov 19 17:33:45 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:35:20 2019-date Tue Nov 19 17:33:45 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018_MC.root : FAILED - time: date Tue Nov 19 17:36:18 2019-date Tue Nov 19 17:33:47 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:36:18 2019-date Tue Nov 19 17:33:47 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_MC.root --fileout file:RelVal_Raw_2018_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:36:18 2019-date Tue Nov 19 17:33:47 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Tue Nov 19 17:36:20 2019-date Tue Nov 19 17:33:54 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:36:20 2019-date Tue Nov 19 17:33:54 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:36:20 2019-date Tue Nov 19 17:33:54 2019 s - exit: 21504
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Tue Nov 19 17:35:45 2019-date Tue Nov 19 17:33:56 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Tue Nov 19 17:35:40 2019-date Tue Nov 19 17:34:02 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:35:40 2019-date Tue Nov 19 17:34:02 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:35:40 2019-date Tue Nov 19 17:34:02 2019 s - exit: 21504
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Tue Nov 19 17:35:56 2019-date Tue Nov 19 17:34:05 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Tue Nov 19 17:35:50 2019-date Tue Nov 19 17:34:14 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:35:50 2019-date Tue Nov 19 17:34:14 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:35:50 2019-date Tue Nov 19 17:34:14 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018_pp_on_AA --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Tue Nov 19 17:36:22 2019-date Tue Nov 19 17:34:17 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:36:22 2019-date Tue Nov 19 17:34:17 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:36:22 2019-date Tue Nov 19 17:34:17 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Tue Nov 19 17:36:09 2019-date Tue Nov 19 17:34:20 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:36:09 2019-date Tue Nov 19 17:34:20 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:36:09 2019-date Tue Nov 19 17:34:20 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Tue Nov 19 17:37:17 2019-date Tue Nov 19 17:35:48 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 19 17:37:17 2019-date Tue Nov 19 17:35:48 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Tue Nov 19 17:37:17 2019-date Tue Nov 19 17:35:48 2019 s - exit: 21504

cmsbuild · 2019-11-19T16:48:23Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

fabiocos · 2019-11-19T21:16:23Z

@smuzaffar the failure in this PR is that previously reported by @civanch

smuzaffar · 2019-11-19T22:08:54Z

please test
@fabiocos , I have added a work around for PR tests to avoid this issue. I will check tomorrow how to fix this properly

cmsbuild · 2019-11-19T22:09:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3540/console Started: 2019/11/19 23:10

cmsbuild · 2019-11-19T23:54:22Z

+1
Tested at: ff441c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c9dbc/3540/summary.html

cmsbuild · 2019-11-19T23:54:26Z

Comparison job queued.

cmsbuild · 2019-11-20T02:01:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c9dbc/3540/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2936360
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2936018
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

fabiocos · 2019-11-20T08:57:35Z

+1

fabiocos · 2019-11-20T09:52:11Z

merge

cmsbuild added this to the CMSSW_11_0_X milestone Nov 4, 2019

cmsbuild added alca-pending code-checks-pending comparison-pending core-pending dqm-pending hlt-pending l1-pending orp-pending pending-signatures tests-pending labels Nov 4, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 4, 2019

cmsbuild mentioned this pull request Nov 4, 2019

DQM: Restructure QTests #28316

Closed

cmsbuild added tests-started and removed tests-pending labels Nov 5, 2019

cmsbuild added tests-approved and removed tests-started labels Nov 5, 2019

cmsbuild added comparison-available and removed comparison-pending labels Nov 5, 2019

schneiml added 2 commits November 11, 2019 14:22

A few more manual conversions.

0fd55ee

cmsbuild added tests-pending tests-started and removed tests-pending labels Nov 19, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Nov 19, 2019

cmsbuild added comparison-pending tests-pending tests-started and removed comparison-notrun tests-rejected tests-pending labels Nov 19, 2019

cmsbuild added tests-approved and removed tests-started labels Nov 19, 2019

cmsbuild added comparison-available and removed comparison-pending labels Nov 20, 2019

cmsbuild added orp-approved and removed orp-pending labels Nov 20, 2019

cmsbuild merged commit e560da8 into cms-sw:master Nov 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DQM: Reduce TH1 Usage #28342

DQM: Reduce TH1 Usage #28342

schneiml commented Nov 4, 2019 •

edited

Loading

cmsbuild commented Nov 4, 2019

cmsbuild commented Nov 4, 2019

cmsbuild commented Nov 4, 2019

tlampen commented Nov 5, 2019

cmsbuild commented Nov 5, 2019 •

edited

Loading

cmsbuild commented Nov 5, 2019

cmsbuild commented Nov 5, 2019

cmsbuild commented Nov 5, 2019

cmsbuild commented Nov 19, 2019

cmsbuild commented Nov 19, 2019

fabiocos commented Nov 19, 2019

smuzaffar commented Nov 19, 2019

cmsbuild commented Nov 19, 2019 •

edited

Loading

cmsbuild commented Nov 19, 2019

cmsbuild commented Nov 19, 2019

cmsbuild commented Nov 20, 2019

fabiocos commented Nov 20, 2019

fabiocos commented Nov 20, 2019

DQM: Reduce TH1 Usage #28342

DQM: Reduce TH1 Usage #28342

Conversation

schneiml commented Nov 4, 2019 • edited Loading

PR description:

PR validation:

cmsbuild commented Nov 4, 2019

cmsbuild commented Nov 4, 2019

cmsbuild commented Nov 4, 2019

tlampen commented Nov 5, 2019

cmsbuild commented Nov 5, 2019 • edited Loading

cmsbuild commented Nov 5, 2019

cmsbuild commented Nov 5, 2019

cmsbuild commented Nov 5, 2019

cmsbuild commented Nov 19, 2019

cmsbuild commented Nov 19, 2019

fabiocos commented Nov 19, 2019

smuzaffar commented Nov 19, 2019

cmsbuild commented Nov 19, 2019 • edited Loading

cmsbuild commented Nov 19, 2019

cmsbuild commented Nov 19, 2019

cmsbuild commented Nov 20, 2019

fabiocos commented Nov 20, 2019

fabiocos commented Nov 20, 2019

schneiml commented Nov 4, 2019 •

edited

Loading

cmsbuild commented Nov 5, 2019 •

edited

Loading

cmsbuild commented Nov 19, 2019 •

edited

Loading