Move Sequence to Task for RecoHI RecoEgamma #28300

jeongeun · 2019-10-29T07:29:17Z

PR description: Move Sequence to Task for RecoHI RecoEgamma cff python files related to hi and cosmic part.

(An extension of the previous task PR#25163, PR#27474 , PR#27640, PR#27887, PR#28050 )

Tested in CMSSW_11_0_X_2019_10_24-2300, the basic test all passed in the CMSSW PR instructions.

cmsbuild · 2019-10-29T07:29:52Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-29T07:34:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28300/12496

This PR adds an extra 112KB to repository

cmsbuild · 2019-10-29T07:35:27Z

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoEgamma/Configuration
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaPhotonProducers
RecoEgamma/PhotonIdentification
RecoHI/Configuration
RecoHI/HiEgammaAlgos
RecoHI/HiJetAlgos
RecoHI/HiMuonAlgos
RecoHI/HiTracking
RecoJets/Configuration
RecoLocalCalo/Configuration
RecoLocalCalo/EcalRecProducers
RecoLocalTracker/Configuration
TrackingTools/GsfTracking

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @yslai, @felicepantaleo, @jainshilpi, @yduhm, @MiheeJo, @echapon, @threus, @varuns23, @seemasharmafnal, @jdolen, @makortel, @lgray, @apsallid, @yenjie, @pieterdavid, @yetkinyilmaz, @Sam-Harper, @afiqaize, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @alesaggio, @ebrondol, @argiro, @dgulhan, @clelange, @mandrenguyen, @gbenelli, @jazzitup, @ahinzmann, @sobhatta, @kurtejung, @gpetruc, @mariadalfonso, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2019-10-29T07:44:26Z

please test

cmsbuild · 2019-10-29T07:44:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3211/console Started: 2019/10/29 08:45

cmsbuild · 2019-10-29T11:39:22Z

-1

Tested at: ce725e4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6a6f6/3211/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

cmsbuild · 2019-10-29T11:39:26Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-11-08T03:47:48Z

Pull request #28300 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2019-11-08T07:24:12Z

please test

cmsbuild · 2019-11-08T07:24:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3387/console Started: 2019/11/08 10:14

cmsbuild · 2019-11-08T11:32:21Z

+1
Tested at: 0c6f615
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6a6f6/3387/summary.html

cmsbuild · 2019-11-08T11:32:25Z

Comparison job queued.

cmsbuild · 2019-11-08T13:27:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6a6f6/3387/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2936360
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2935992
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.148 KiB( 33 files compared)
DQMHistoSizes: changed ( 140.53 ): -0.039 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 140.53 ): -0.039 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 7.3 ): -0.035 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 7.3 ): -0.035 KiB MessageLogger/Errors
Checked 147 log files, 16 edm output root files, 34 DQM output files

perrotta · 2019-11-08T13:32:59Z

+1

Sequences moved to Tasks in the packages as planned
Jenkins tests pass and show no differences in reco output
Differences in DQM histograms for HCal TDC are not originated by this PR, see also issue Non reproducibility of LETDCTime HCAL DigiTask histograms in PR tests #28367

cmsbuild · 2019-11-08T13:33:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-11-08T21:33:18Z

+1

fabiocos · 2019-11-09T08:25:16Z

@perrotta @jeongeun after the integration there is a failure in wf 150

perrotta

@jeongeun , this should fix wf 150
Could you please prepare a fix PR with it, and test it with wf 150?

perrotta · 2019-11-09T09:24:59Z

RecoHI/HiTracking/python/hiDetachedTripletStep_cff.py

                                     hiDetachedTripletStepQual)
+hiDetachedTripletStep = cms.Sequence(hiDetachedTripletStepTask)
 hiDetachedTripletStep_Phase1 = hiDetachedTripletStep.copy()
 hiDetachedTripletStep_Phase1.replace(hiDetachedTripletStepTracksHitDoublets, hiDetachedTripletStepTracksHitDoubletsCA)


These have to be replaced in the Task now, not in the sequence

perrotta · 2019-11-09T09:26:13Z

RecoHI/HiTracking/python/hiDetachedTripletStep_cff.py

                                     hiDetachedTripletStepQual)
+hiDetachedTripletStep = cms.Sequence(hiDetachedTripletStepTask)
 hiDetachedTripletStep_Phase1 = hiDetachedTripletStep.copy()
 hiDetachedTripletStep_Phase1.replace(hiDetachedTripletStepTracksHitDoublets, hiDetachedTripletStepTracksHitDoubletsCA)


These have to be replaced in the Task now, not in the sequence

perrotta · 2019-11-09T09:29:32Z

RecoHI/HiTracking/python/hiDetachedTripletStep_cff.py

                                     hiDetachedTripletStepQual)
+hiDetachedTripletStep = cms.Sequence(hiDetachedTripletStepTask)
 hiDetachedTripletStep_Phase1 = hiDetachedTripletStep.copy()
 hiDetachedTripletStep_Phase1.replace(hiDetachedTripletStepTracksHitDoublets, hiDetachedTripletStepTracksHitDoubletsCA)


These have to be replaced in the Task now, not in the sequence

perrotta · 2019-11-09T09:29:49Z

RecoHI/HiTracking/python/hiLowPtTripletStep_cff.py

                                        hiLowPtTripletStepQual
                                        )
+hiLowPtTripletStep = cms.Sequence(hiLowPtTripletStepTask)
 hiLowPtTripletStep_Phase1 = hiLowPtTripletStep.copy()
 hiLowPtTripletStep_Phase1.replace(hiLowPtTripletStepTracksHitDoublets, hiLowPtTripletStepTracksHitDoubletsCA)


These have to be replaced in the Task now, not in the sequence

perrotta · 2019-11-10T18:31:35Z

@jeongeun @fabiocos : just to speed up and avoid the needs of reverting this PR in case a pre-release wants to be cut, I submitted a fix PR with #28372

jeongeun added 5 commits October 25, 2019 12:42

move sequence to task recoHI

8c8c8fb

small fix

d8ded48

small fix2

9dc0c0e

fix3

c1937ca

last fix

ce725e4

cmsbuild added this to the CMSSW_11_0_X milestone Oct 29, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 29, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 29, 2019

cmsbuild mentioned this pull request Oct 29, 2019

[HBHE] Update MahiDebugger and fix nP in NNLS #28193

Closed

Update HIPixel3PrimTracks_cfi.py

6c188f6

cmsbuild removed the code-checks-approved label Oct 30, 2019

cmsbuild added the code-checks-approved label Nov 8, 2019

cmsbuild added tests-started and removed tests-pending labels Nov 8, 2019

cmsbuild added tests-approved and removed tests-started labels Nov 8, 2019

cmsbuild added comparison-available and removed comparison-pending labels Nov 8, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Nov 8, 2019

cmsbuild added orp-approved and removed orp-pending labels Nov 8, 2019

cmsbuild merged commit d05031d into cms-sw:master Nov 8, 2019

perrotta reviewed Nov 9, 2019

View reviewed changes

perrotta mentioned this pull request Nov 10, 2019

Fix TripletStep Task for HI Phase1 #28372

Merged

jeongeun mentioned this pull request Nov 14, 2019

Move Sequence to Task for RecoTauTag RecoCTPPS #28399

Merged

jeongeun mentioned this pull request Dec 22, 2019

Move Sequence to Task Reconstruction_cff #28678

Merged

jeongeun deleted the SeqToTask_RecoHI branch May 26, 2020 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Sequence to Task for RecoHI RecoEgamma #28300

Move Sequence to Task for RecoHI RecoEgamma #28300

jeongeun commented Oct 29, 2019 •

edited

Loading

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

perrotta commented Oct 29, 2019

cmsbuild commented Oct 29, 2019 •

edited

Loading

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Nov 8, 2019

perrotta commented Nov 8, 2019

cmsbuild commented Nov 8, 2019 •

edited

Loading

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

perrotta commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

fabiocos commented Nov 8, 2019

fabiocos commented Nov 9, 2019

perrotta left a comment

perrotta Nov 9, 2019

perrotta Nov 9, 2019

perrotta Nov 9, 2019

perrotta Nov 9, 2019

perrotta commented Nov 10, 2019

Move Sequence to Task for RecoHI RecoEgamma #28300

Move Sequence to Task for RecoHI RecoEgamma #28300

Conversation

jeongeun commented Oct 29, 2019 • edited Loading

PR description: Move Sequence to Task for RecoHI RecoEgamma cff python files related to hi and cosmic part.

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

perrotta commented Oct 29, 2019

cmsbuild commented Oct 29, 2019 • edited Loading

cmsbuild commented Oct 29, 2019

cmsbuild commented Oct 29, 2019

cmsbuild commented Nov 8, 2019

perrotta commented Nov 8, 2019

cmsbuild commented Nov 8, 2019 • edited Loading

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

perrotta commented Nov 8, 2019

cmsbuild commented Nov 8, 2019

fabiocos commented Nov 8, 2019

fabiocos commented Nov 9, 2019

perrotta left a comment

Choose a reason for hiding this comment

perrotta Nov 9, 2019

Choose a reason for hiding this comment

perrotta Nov 9, 2019

Choose a reason for hiding this comment

perrotta Nov 9, 2019

Choose a reason for hiding this comment

perrotta Nov 9, 2019

Choose a reason for hiding this comment

perrotta commented Nov 10, 2019

jeongeun commented Oct 29, 2019 •

edited

Loading

cmsbuild commented Oct 29, 2019 •

edited

Loading

cmsbuild commented Nov 8, 2019 •

edited

Loading