Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reconstruction_Data for move of jetCorrectorsForReco to Task #27931

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Sep 4, 2019

PR description:

Following the migration of jet reconstruction sequences to Task in #27887 and the failure in wf 140.54 deriving from this move discussed in #27919 , the updated suggested by @jeongeun is provided.

PR validation:

Test wf 140.54 and 136.85 run successfully.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

The code-checks are being triggered in jenkins.

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 4, 2019

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27931/11765

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @fabiocos, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 4, 2019

please test workflow 140.54

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 4, 2019

@slava77 @perrotta @jeongeun FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2364/console Started: 2019/09/04 18:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be60e6/2364/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-be60e6/140.54_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955700
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2955358
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 4, 2019

+operations

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 4, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@slava77
Copy link
Contributor

slava77 commented Sep 4, 2019

@slava77 @perrotta @jeongeun FYI

Thank you.
This seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants