Update GEMPadDigi clustering procedure

[dildick]

PR description:

Update of the clustering procedure so it matches the implementation in the GEM optohybrid firmware.

In the current version of the algorithm, cluster finding is segmented into two separate halves of the GE1/1 chambers. Thus, each one of the trigger fibers can transmit clusters only from the half of the chamber that it corresponds to. For GE2/1, there are four separate quarts of the GE2/1 chamber.

This has the downside of being unable to transmit more than 4 clusters when they occur within that side of the chamber, so there will be a slightly higher rate of cluster overflow. For GE2/1 each OH can transmit up to 5 clusters.

Note: GE1/1 does not have 2 physical optohybrids. There is only one optohybrid per chamber, but the firmware sees two independent halves. So nOHGE11_ really means the number of independent optohybrid sectors. On the other hand nOHGE21_ is the actual number of optohybrids on the chamber. However, the emulator should match the firmware, despite this subtle difference.

PR validation:

I tested this pull request on a customized multi-muon gun. I simulated 10 events, each with 100 muons and 100 antimuons propagating between 1.55 < |eta| < 2.15 - to emulate high pileup conditions in the GE1/1 region. Print-outs (not included in the pull request) show

• Example GE1/1

Analyzing optohybrid 1
	Adding cluster to final collection Re -1 Ri 1 St 1 La 1 Ch 7 Ro 1   bx: 0 pads:  29
	Adding cluster to final collection Re -1 Ri 1 St 1 La 1 Ch 7 Ro 1   bx: 0 pads:  60
	Adding cluster to final collection Re -1 Ri 1 St 1 La 1 Ch 7 Ro 1   bx: 0 pads:  127
	Adding cluster to final collection Re -1 Ri 1 St 1 La 1 Ch 7 Ro 3   bx: 0 pads:  63 64
	Rejecting cluster  Re -1 Ri 1 St 1 La 1 Ch 7 Ro 3   bx: 0 pads:  70 71
Analyzing optohybrid 2
	Adding cluster to final collection Re -1 Ri 1 St 1 La 1 Ch 7 Ro 7   bx: 1 pads:  181

• Example GE2/1:

Analyzing optohybrid 1
	Adding cluster to final collection Re 1 Ri 1 St 2 La 1 Ch 11 Ro 2   bx: 0 pads:  207
Analyzing optohybrid 2
	Adding cluster to final collection Re 1 Ri 1 St 2 La 1 Ch 11 Ro 4   bx: 0 pads:  271 272
Analyzing optohybrid 3
	Adding cluster to final collection Re 1 Ri 1 St 2 La 1 Ch 11 Ro 5   bx: 0 pads:  61
	Adding cluster to final collection Re 1 Ri 1 St 2 La 1 Ch 11 Ro 5   bx: 0 pads:  119
	Adding cluster to final collection Re 1 Ri 1 St 2 La 1 Ch 11 Ro 5   bx: 0 pads:  123
	Adding cluster to final collection Re 1 Ri 1 St 2 La 1 Ch 11 Ro 5   bx: 0 pads:  244
	Adding cluster to final collection Re 1 Ri 1 St 2 La 1 Ch 11 Ro 5   bx: 0 pads:  262
	Rejecting cluster  Re 1 Ri 1 St 2 La 1 Ch 11 Ro 5   bx: 0 pads:  265 266 267 268
	Rejecting cluster  Re 1 Ri 1 St 2 La 1 Ch 11 Ro 6   bx: 0 pads:  346
	Rejecting cluster  Re 1 Ri 1 St 2 La 1 Ch 11 Ro 6   bx: 0 pads:  375
Analyzing optohybrid 4

Attention: @tahuang1991 @jiafulow @jshlee

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27832/11564

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

SimMuon/GEMDigitizer

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@jshlee, @jhgoh this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[dildick]

This pull request may need to be back-ported for releases targeting Run-3 studies.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2129/console Started: 2019/08/23 06:05

[cmsbuild]

+1
Tested at: 43d19f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ec19f/2129/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ec19f/2129/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[civanch]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1