Complete the implementation of RPC Digi Collection Merger started in PR #24613

[dilsonjd]

PR description:

• Complete the implementation of RPC Digi Collection Merger started in PR RPC Digi Collection Merger #24613
• Replace the temporary muonRPCNewDigis and rpcNewRecHits modules implemented in RPC Digi Collection Merger #24613 to the "default" muonRPCDigis and rpcRecHits

PR validation:

scram b runtests
scram b code-checks
scram b code-formats

runTheMatrix.py -l limited -i all --ibeos
32 31 30 24 12 2 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed

@ftorresd @mileva @BrieucF @jhgoh

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27672/11247

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665, Light by light modifier 1100 pre1 #27633
  • File RecoLocalMuon/Configuration/python/RecoLocalMuonCosmics_cff.py modified in PR(s): Moving Sequence to Task :RecoLocalMuon RecoMuon RecoEgamma RecoEcal RecoHI #27640
  • File RecoLocalMuon/Configuration/python/RecoLocalMuon_cff.py modified in PR(s): Moving Sequence to Task :RecoLocalMuon RecoMuon RecoEgamma RecoEcal RecoHI #27640

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27672/11247/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27672/11247/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27672/11248

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665, Light by light modifier 1100 pre1 #27633
  • File RecoLocalMuon/Configuration/python/RecoLocalMuonCosmics_cff.py modified in PR(s): Moving Sequence to Task :RecoLocalMuon RecoMuon RecoEgamma RecoEcal RecoHI #27640
  • File RecoLocalMuon/Configuration/python/RecoLocalMuon_cff.py modified in PR(s): Moving Sequence to Task :RecoLocalMuon RecoMuon RecoEgamma RecoEcal RecoHI #27640

[cmsbuild]

A new Pull Request was created by @dilsonjd (Dilson de Jesus Damião) for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
EventFilter/RPCRawToDigi
RecoLocalMuon/Configuration
RecoLocalMuon/RPCRecHit

@perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @Martin-Grunewald, @bellan, @rovere, @thomreis, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27672/11252

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665, Light by light modifier 1100 pre1 #27633
  • File RecoLocalMuon/Configuration/python/RecoLocalMuonCosmics_cff.py modified in PR(s): Moving Sequence to Task :RecoLocalMuon RecoMuon RecoEgamma RecoEcal RecoHI #27640
  • File RecoLocalMuon/Configuration/python/RecoLocalMuon_cff.py modified in PR(s): Moving Sequence to Task :RecoLocalMuon RecoMuon RecoEgamma RecoEcal RecoHI #27640

[cmsbuild]

Pull request #27672 was updated. @perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1786/console Started: 2019/08/01 23:02

[cmsbuild]

Pull request #27672 was updated. @perrotta, @kpedro88, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2175/console Started: 2019/08/25 19:49

[cmsbuild]

+1
Tested at: 65e348d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373487/2175/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373487/2175/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[perrotta]

+1

• As discussed during the reco meeting on Aug 23, the RPCCPPF packer is not available yet, and the MC cannot be at the moment be configured the same way as for data. The temporary solution proposed in this PR should be accepted now in CMSSW,
• RPC people commits in preparing a more stable and correct solution by implementing a packer/unpacker code for CPPF within the next few months, and in any case in time for the major Run3 MC productions. The special RPCDigiMerger for MC will be reverted by then, and the same RPCDigiMerger module config will be used for both data and MC.
• Jenkins tests pass and show no differences, as planned

[perrotta]

Issue #27869 has been opened to keep track of the progresses in the implementation of the CPPF packer/unpacker in CMSSW

[kpedro88]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1