Saving generator protons from pile-up for standard mixing and premixing #20172
Conversation
…ns in standard mixing and premixing scenarios.
|
A new Pull Request was created by @antoniovilela for master. It involves the following packages: Configuration/StandardSequences @perrotta, @civanch, @mdhildreth, @monttj, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
@antoniovilela |
| @@ -90,6 +90,8 @@ | |||
| 'keep GenLumiInfoHeader_generator_*_*', | |||
| 'keep GenLumiInfoProduct_*_*_*', | |||
| 'keep GenEventInfoProduct_generator_*_*', | |||
| 'keep recoGenParticles_genPUProtons_*_*', | |||
| 'keep recoGenParticles_*_genPUProtons_*', | |||
There was a problem hiding this comment.
why there are two collections?
There was a problem hiding this comment.
@gpetruc, @slava77
There will be only one collection saved, but there are two possible workflows:
i) Standard mixing, where the collection is saved from the 'genPUProtons' module in the DIGI sequence:
Type Module Label Process
vectorreco::GenParticle "genPUProtons" "" "HLT"
ii) Pre-mixing, where the collection is saved in the premixed sample and later copied by the DataMixingModule ('mixData'), with label 'genPUProtons':
Type Module Label Process
vectorreco::GenParticle "mixData" "genPUProtons" "DIGI2RAW"
There was a problem hiding this comment.
these can/should be changed to be an EDAlias so that the only saved branches are recoGenParticles_genPUProtons
See examples in SimGeneral/MixingModule/python/aliases_PreMix_cfi.py
it will be something like this (perhaps for both mix and mixData)
genPUProtons = cms.EDAlias(
mixData = cms.VPSet(cms.PSet(
type = cms.string('recoGenParticles')
))
)I tried this in 250202.17 (premix) and it worked:
- default:
recoGenParticles_mixData_genPUProtons_HLT. - with the modification (and keep of only
recoGenParticles_genPUProtons__*) :recoGenParticles_genPUProtons_genPUProtons_HLT
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20172/126 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20172/126/git-diff.patch In future, you can run |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
@slava77 Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event) |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Pull request #20172 was updated. @perrotta, @civanch, @mdhildreth, @monttj, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
merge |
forthommel
deleted the
93X-GenPUProtonProducer-Premixing-StandardSequences
branch
As agreed with CT-PPS simulation conveners, this is a follow-up of the previous request: #18347
With respect to the above PR (not merged) it has updates to the new GenPUProtonProducer and to DataMixingPileupCopy in the DataMixingModule and includes the new 'genPUProtons' sequence for mixing and premixing workflows.
@fabferro , @forthommel , @perrozzi , @mdhildreth