Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] Explicitly added cmake and gmake deps #8913

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Dec 24, 2023

This fixes the build issues for slc7 where cmake is not part of cmssw-el7 container

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/master.

@smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 24, 2023

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for slc7_amd64_gcc12

@smuzaffar smuzaffar merged commit f2c9dfc into IB/CMSSW_14_0_X/master Dec 24, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70070/36676/summary.html
COMMIT: c056f89
CMSSW: CMSSW_14_0_X_2023-12-24-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8913/36676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70070/36677/summary.html
COMMIT: c056f89
CMSSW: CMSSW_14_0_X_2023-12-23-1100/slc7_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8913/36677/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70070/36677/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70070/36677/git-merge-result

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 54751 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247277
  • DQMHistoTests: Total failures: 134156
  • DQMHistoTests: Total nulls: 269
  • DQMHistoTests: Total successes: 3112830
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6.119999999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12634.0 ): 5.430 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.023 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044,... ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.288 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.303 KiB SiStrip/MechanicalView
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 14 / 46 workflows

@smuzaffar smuzaffar deleted the smuzaffar-patch-3 branch December 31, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants