Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for RecoEgamma-PhotonIdentification to V01-01-00 #6853

Conversation

cmsbuild
Copy link
Contributor

Move RecoEgamma-PhotonIdentification data to new tag, see
cms-data/RecoEgamma-PhotonIdentification#8

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

+externals
this is tested, it need to go with
cms-sw/cmssw#33518

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor Author

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf27fc/14668/summary.html
COMMIT: f227f34
CMSSW: CMSSW_12_0_X_2021-04-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6853/14668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877605
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877581
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor

@qliphy I think this was needed by cms-sw/cmssw#33518 and because it didn't get in the relvals are failing :/

@mrodozov
Copy link
Contributor

indeed the missing file is the only addition in this data PR:
https://github.com/cms-data/RecoEgamma-PhotonIdentification/pull/8/files

@mrodozov mrodozov merged commit 93a849f into IB/CMSSW_12_0_X/master Apr 29, 2021
@smuzaffar smuzaffar deleted the update-RecoEgamma-PhotonIdentification-to-V01-01-00 branch May 3, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants