Make CWS multi-contest #594

wil93 · 2016-03-26T00:25:32Z

With this patch, ContestWebServer does not require a -c flag anymore. When you start CWS, it will expose a list of all available contests on /, and you can click on the contest that you're interested in.

The former cookie behavior was to save 2 cookies: login and unread_count. The new cookie behavior is to save 2*N cookies where N is the number of contests. Each cookie will either be <contest-name>_login or <contest-name>_unread_count.

This PR depends on #545

This change is

wil93 · 2016-03-26T00:38:29Z

cms/server/contest/handlers/taskusertest.py

        participation = self.current_user

        if not self.r_params["testing_enabled"]:
-            self.redirect("/")
-            return
+            raise tornado.web.HTTPError(403)


This change is not needed for the overall patch, but I figured it was a sensible change (which didn't require a different commit or a different PR)

wil93 · 2016-08-23T14:43:08Z

Seeing that #545 was merged, my faith in this PR was restored and I decided to try and rebase it 😄

It was quite hard (especially because of these commits: cd09d99, 8f0ec9f and 7442fac).

Please let's merge this PR before other commits break it again 🙏

lucach · 2016-09-17T08:04:43Z

cms/server/contest/handlers/contest.py

+
+        ret["contest"] = self.contest
+        ret["contest_root"] = ret["url_root"]
+        ret["real_contest_root"] = "/"


Can you explain the semantic of contest_root and real_contest_root?
In some scenarios, this PR causes trouble with StartHandler and LogoutHandler.

url_root includes all necessary ../ to go back to the root, so if the URL is localhost:8888/a/b/c then url_root is ../../

real_url_root is always /

contest_root is url_root + the name of the contest, real_contest_root is / + the contest name.

Anyway, I once saw some issues with LogoutHandler, but then I think I fixed them. Do you still see issues?

Assume that current URL is localhost:8888/a. Let's start our timer to compete, actually calling StartHandler.
Now that I've understood the meaning, variables are correctly setted as:

url_root = ..

contest_root = ../a

real_contest_root = /a

StartHandler tries to redirect the user to ../a (see https://github.com/wil93/cms/blob/multi_cws/cms/server/contest/handlers/main.py#L148)
but our custom redirector (see https://github.com/wil93/cms/blob/multi_cws/cms/server/util.py#L714) creates the invalid URL localhost:8888/a/..../a

I thought I had fixed that, but it seems this bug is still on the multi_cws branch 😕

I think I fixed it in PR #646 (which is based on this one). I'll backport the fixes here 😄

Done, thanks 😄 it looks like I had fixed this in the wrong branch (and just for LogoutHandler, thus leaving a broken StartHandler)

Everything works as expected now ;)

andreyv · 2016-12-11T11:31:47Z

With this branch I don't see a language selection option in CWS. Can you reproduce this?

wil93 · 2016-12-11T11:47:49Z

@andreyv Yes, I had noticed that some time ago but didn't investigate. I tried to fix it now, it should work

wil93 · 2017-03-20T14:10:46Z

stefano-maggiolo · 2017-03-27T02:04:52Z

I rebased this PR to master - it was great fun, but I suggest we don't do it again and try to close it asap, by commenting here and fixing up in my branch (once done commenting, I can publish my branch to let you try it out, if you want)

Unless you have better ideas, that is...

Looking again at the code now.

wil93 · 2017-03-27T10:18:01Z

try to close it asap, by commenting here and fixing up in my branch

I'm not sure I understand what's the plan 😅

lw · 2017-03-28T13:39:42Z

cms/server/contest/server.py

@@ -83,15 +84,25 @@ def __init__(self, shard, contest):
                              "contest_listen_address and contest_listen_port "
                              "in cms.conf." % __name__)

+        self.contest = contest
+        del contest


Why are you deleting a local variable?

lw · 2017-03-28T13:41:15Z

How does this work when CWS is managed by RS? From what I see I understand that CWS will always be started in single-contest mode. Is that correct?

wil93 · 2017-03-28T13:46:26Z

If you put -c some_number, then it will start as usual (single contest), otherwise it will require a prefix /contest_name/ in the URL. In the home page a list of contests will be shown. The reason of deleting the local variable was just to ensure a single point of truth, I think I've seen somebody using that practice Il mar 28 mar 2017, 15:41 Luca Wehrstedt <notifications@github.com> ha scritto:

…

How does this work when CWS is managed by RS? From what I see I understand that CWS will always be started in single-contest mode. Is that correct? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#594 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOc8QZmRgvQGPGsQoP-IXQ6kIwcUZH1ks5rqQ37gaJpZM4H5HWi> .

lw · 2017-03-28T13:50:06Z

You didn't understand my question. I wasn't talking about how to launch CWS from the command line. I was in some sense saying that it appears to me that it's impossible to launch CWS in multi-contest mode when RS is used to manage it. Am I wrong?

Also, AFAIK, we don't do that, we don't remove local variables.

stefano-maggiolo · 2017-03-28T13:55:52Z

@lerks I don't see it as a problem for the first submitted version of this code.

@wil93 I wanted to comment here, but my work is done mostly when I don't have internet connection and reviewable doesn't make it easy - how about I jot down a first fixup commit with straightforward stuff, send a PR with these commits and my fixups, and we can continue the discussion there?

wil93 · 2017-03-28T14:27:30Z

Yes I did not modify RS so it will launch CWS as single contest. I don't use RS (I prefer supervisord) so I didn't think about this. Stefano: OK for me Il mar 28 mar 2017, 15:55 Stefano Maggiolo <notifications@github.com> ha scritto:

…

@lerks <https://github.com/lerks> I don't see it as a problem for the first submitted version of this code. @wil93 <https://github.com/wil93> I wanted to comment here, but my work is done mostly when I don't have internet connection and reviewable doesn't make it easy - how about I jot down a first fixup commit with straightforward stuff, send a PR with these commits and my fixups, and we can continue the discussion there? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#594 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOc8fDU0Lsz1KTss57FynCGMZrqNePFks5rqRFpgaJpZM4H5HWi> .

stefano-maggiolo · 2017-04-02T11:47:29Z

See #739

stefano-maggiolo · 2017-04-04T09:24:26Z

Damn, just a tad out of our service level agreement of one year ;P

Merged!

wil93 force-pushed the multi_cws branch 2 times, most recently from 250c7ce to 3989ad8 Compare March 26, 2016 00:32

wil93 reviewed Mar 26, 2016
View reviewed changes

wil93 force-pushed the multi_cws branch 3 times, most recently from fee5af7 to c732e40 Compare March 26, 2016 16:08

wil93 force-pushed the multi_cws branch from bf5732c to 846fc04 Compare April 12, 2016 19:00

wil93 force-pushed the multi_cws branch 2 times, most recently from 2d01624 to 8d867ab Compare July 4, 2016 14:21

wil93 mentioned this pull request Aug 16, 2016

Using CMS as an online judge server #643

Open

wil93 force-pushed the multi_cws branch from 21b991a to e28ae8f Compare August 23, 2016 14:39

wil93 force-pushed the multi_cws branch from e28ae8f to c9b7f39 Compare August 23, 2016 14:58

wil93 mentioned this pull request Aug 23, 2016

Support open participation in contests + hidden contests #646

Open

wil93 force-pushed the multi_cws branch from 73a49e6 to 35770ff Compare September 12, 2016 23:20

lucach reviewed Sep 17, 2016

View reviewed changes

wil93 mentioned this pull request Oct 16, 2016

Two or more contests in parallel #362

Closed

wil93 added 3 commits October 16, 2016 15:24

Make CWS multi-contest

bc5dfae

Tentative fix for serving CWS with a prefix

9105320

Clarify reasoning behind CommonRequestHandler.redirect()

1bd0db8

wil93 force-pushed the multi_cws branch from 5033f48 to 1bd0db8 Compare October 16, 2016 13:24

Fix odd redirect bug

383abc8

wil93 referenced this pull request Dec 8, 2016

Small refactoring to avoid duplication on submission errors

c395073

Attemp to fix language selection

c86b684

karliss mentioned this pull request Dec 19, 2016

Vulnerability of CSRF #453

Closed

lw reviewed Mar 28, 2017

View reviewed changes

lw assigned stefano-maggiolo Apr 1, 2017

stefano-maggiolo closed this Apr 4, 2017

andreyv mentioned this pull request Jan 16, 2018

HTML fixes #819

Closed

wil93 mentioned this pull request Aug 10, 2021

Register in a contest with an already existing user account #1187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make CWS multi-contest #594

Make CWS multi-contest #594

wil93 commented Mar 26, 2016

wil93 Mar 26, 2016

wil93 commented Aug 23, 2016 •

edited

Loading

lucach Sep 17, 2016

wil93 Sep 18, 2016

lucach Sep 18, 2016

wil93 Sep 18, 2016

wil93 Sep 18, 2016

lucach Sep 18, 2016

andreyv commented Dec 11, 2016

wil93 commented Dec 11, 2016

wil93 commented Mar 20, 2017

stefano-maggiolo commented Mar 27, 2017

wil93 commented Mar 27, 2017

lw Mar 28, 2017

lw commented Mar 28, 2017

wil93 commented Mar 28, 2017 via email

lw commented Mar 28, 2017

stefano-maggiolo commented Mar 28, 2017

wil93 commented Mar 28, 2017 via email

stefano-maggiolo commented Apr 2, 2017

stefano-maggiolo commented Apr 4, 2017

Make CWS multi-contest #594

Make CWS multi-contest #594

Conversation

wil93 commented Mar 26, 2016

Choose a reason for hiding this comment

wil93 commented Aug 23, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreyv commented Dec 11, 2016

wil93 commented Dec 11, 2016

wil93 commented Mar 20, 2017

stefano-maggiolo commented Mar 27, 2017

wil93 commented Mar 27, 2017

Choose a reason for hiding this comment

lw commented Mar 28, 2017

wil93 commented Mar 28, 2017 via email

lw commented Mar 28, 2017

stefano-maggiolo commented Mar 28, 2017

wil93 commented Mar 28, 2017 via email

stefano-maggiolo commented Apr 2, 2017

stefano-maggiolo commented Apr 4, 2017

wil93 commented Aug 23, 2016 •

edited

Loading