Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RWS' main page / instead of /Ranking.html #1035

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

stefano-maggiolo
Copy link
Member

@stefano-maggiolo stefano-maggiolo commented Oct 3, 2018

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #1035 into master will increase coverage by 0.11%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   62.17%   62.29%   +0.11%     
==========================================
  Files         227      227              
  Lines       16548    16562      +14     
==========================================
+ Hits        10289    10317      +28     
+ Misses       6259     6245      -14
Flag Coverage Δ
#functionaltests 46.32% <41.17%> (+0.22%) ⬆️
#unittests 43.35% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
cmsranking/RankingWebServer.py 43.01% <41.17%> (-0.31%) ⬇️
cms/service/esoperations.py 79.57% <0%> (-4.93%) ⬇️
cms/db/util.py 50% <0%> (-1.52%) ⬇️
cms/grading/Sandbox.py 67.98% <0%> (-0.18%) ⬇️
cms/io/PsycoGevent.py 68.57% <0%> (ø) ⬆️
cms/io/rpc.py 90.13% <0%> (ø) ⬆️
cms/server/admin/handlers/base.py 69.49% <0%> (+0.33%) ⬆️
cms/server/admin/handlers/task.py 42.8% <0%> (+0.38%) ⬆️
cms/server/admin/handlers/dataset.py 26.23% <0%> (+0.61%) ⬆️
cms/db/filecacher.py 76.89% <0%> (+0.66%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf4ca0...3fcc1da. Read the comment docs.

Copy link
Member

@lw lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants