Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING: the constructor "new JSONEditor(...)" is deprecated since v1. Please use "createJSONEditor(...)" instead. #98

Closed
4 tasks done
arkhaiel opened this issue Oct 8, 2024 · 0 comments · Fixed by #99

Comments

@arkhaiel
Copy link
Contributor

arkhaiel commented Oct 8, 2024

Before you start, please make sure to:

  • Read the document
  • Have tried the latest version
  • Search to see if your issue already exists

Link to minimal reproduction

https://cloydlau.github.io/playground/json-editor-vue/

Validation

  • ⚠️ I understand that invalid, incomplete or superfluous reproduction can lead to this issue being closed

Describe the bug and steps to reproduce

I use nuxthub and nuxt devtools, each time there's an instance of jsoneditor-vue created I have this warning.
Looking to the vanilla-jsoneditor I see there's a breaking change in v1 and it's the origin of the warning.

I will create a PR to fix the warning !

Thanks for this module ❤️

System Info

No response

Package Manager

pnpm

cloydlau added a commit that referenced this issue Oct 8, 2024
* apply a breaking change

Apply vanilla-jsoneditor v1 breaking change related to the createJSONEditor instead of new JSONEditor

* fix: #98

---------

Co-authored-by: Cloyd Lau <31238760+cloydlau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant