Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for database creation to succeed. #4

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Wait for database creation to succeed. #4

merged 1 commit into from
Jan 20, 2020

Conversation

lgruen
Copy link

@lgruen lgruen commented Jan 19, 2020

No description provided.

@googlebot googlebot added the cla: yes CLA signed label Jan 19, 2020
@lgruen lgruen requested a review from larkee January 19, 2020 23:45
larkee
larkee approved these changes Jan 20, 2020
View reviewed changes
Copy link
Collaborator

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit for readability purposes would be to assign the operation and then call result() on it:

op = database.create()
op.result()  # Wait for operation to complete

But functionally this should work fine

@lgruen lgruen merged commit fd1fb7a into cloudspannerecosystem:master Jan 20, 2020
@lgruen lgruen mentioned this pull request Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgruen @larkee @googlebot