fix: Improve error wrapping #512
Conversation
| if err := eg.Wait(); err != nil { | ||
| return fmt.Errorf("got EOF. failed to wait for plugin: %w", err) | ||
| return fmt.Errorf("got EOF. plugin returned: %w", err) |
There was a problem hiding this comment.
EOF is not an error necessarily (it usually means the stream was closed), so I'm not sure we want to report it (we can log it instead as Debug). Also to be consistent we should add plugin returned to everywhere we do eg.Wait(), like lines 105 and 114 in this file.
You can see https://github.com/cloudquery/plugin-sdk/pull/461/files for reference.
We can also reduce the nesting of handling EOF, but that can be done in another PR, see #463 for reference
| case ch <- clientResource: | ||
| } | ||
| } | ||
|
|
||
| close(ch) | ||
| if err := eg.Wait(); err != nil { | ||
| return err | ||
| return fmt.Errorf("write client returned: %w", err) |
There was a problem hiding this comment.
| return fmt.Errorf("write client returned: %w", err) | |
| return fmt.Errorf("write client failed with error: %w", err) |
Also shouldn't we use the same message above, i.e. instead plugin returned -> write failed
|
An additional comment on this. gRPC doesn't support error wrapping, so using |
|
Closing as this was addressed in additional PR. |
No description provided.