fix: Log warning instead of erroring out of PK component validation failure #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
approved these changes
Dec 31, 2024
bbernays
approved these changes
Dec 31, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
🤖 I have created a release *beep* *boop* --- ## [4.72.6](v4.72.5...v4.72.6) (2025-01-07) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.4 ([#2044](#2044)) ([c7bd2d2](c7bd2d2)) * **deps:** Update module github.com/goccy/go-json to v0.10.4 ([#2040](#2040)) ([f6e0201](f6e0201)) * **deps:** Update module google.golang.org/protobuf to v1.36.1 ([#2043](#2043)) ([13437c2](13437c2)) * **deps:** Update opentelemetry-go monorepo ([#2042](#2042)) ([e6123c3](e6123c3)) * Log warning instead of erroring out of PK component validation failure ([#2039](#2039)) ([c98b5c5](c98b5c5)) * Validate missing PK components ([#2037](#2037)) ([d2cff6b](d2cff6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #2037.
Gave it another thought and instead of erroring out might be better to log a warning (for starts) so we can fix the issues instead of breaking tables in the AWS plugin.
Even when a PK component has a null value CQ ID will still be calculated with the null value, so the data can be inserted (opposed to a missing PK where in the case of DB destinations the insertion will fail)
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)