Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3 AZs for Terraform 0.11 #29

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

pkoraca
Copy link

@pkoraca pkoraca commented Oct 15, 2019

Hello,

Here's PR for Terraform 0.11 support for 3 AZ. Also, terraform-null-label module was bumped since the old version was omitting hyphen character.

aknysh
aknysh previously requested changes Oct 18, 2019
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pkoraca
please run terraform fmt and rebuild README by executing these commands:

make init
make readme/deps
make readme

It will add the new variables and outputs to README.md automatically.

In general, any changes to README should be made in README.yaml (not in this case), and after that executing the commands above will rebuild README.yaml into README.md and add all new variables and outputs to README.md

thanks

@maximmi maximmi dismissed aknysh’s stale review February 26, 2020 23:34

comments were addressed

@maximmi maximmi merged commit c7d3a49 into cloudposse:0.11/master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants