Add cold storage support #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
|
@dm3ch we can not run tests for this PR at the moment. |
|
@goruha Merged current master |
|
/test all |
dm3ch
force-pushed
the
cold-storage-support
branch
from
68fc51b to
f088595
Compare
|
@goruha Yep, merged the wrong branch. Now dropped unwanted changes from this PR. |
|
/test all |
|
@goruha I'm not sure how to better fix this test. I even don't understand why the test tries to enable cold storage if I haven't modified any tests and made it disabled by default. |
|
@dm3ch it does not enable cold storage. I think you have to make this block |
|
Ok, wrapped to dynamic block |
dm3ch
force-pushed
the
cold-storage-support
branch
from
3cb86c6 to
470ba57
Compare
|
/test all |
goruha
approved these changes
Feb 18, 2023
|
@dm3ch LGTM Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
cluster_config.cold_storage_options.enabledwhy