Add option to apply security groups to domain #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -167,7 +167,7 @@ resource "aws_elasticsearch_domain" "default" { | |||
| for_each = var.vpc_enabled ? [true] : [] | |||
|
|
|||
| content { | |||
| security_group_ids = [join("", aws_security_group.default.*.id)] | |||
| security_group_ids = var.create_security_group ? [join("", aws_security_group.default.*.id)] : var.security_groups | |||
There was a problem hiding this comment.
Ensure AWS Elasticsearch has node-to-node encryption enabled
Resource: module.elasticsearch.aws_elasticsearch_domain.default | ID: BC_AWS_ELASTICSEARCH_5
Description
The AWS Elasticsearch Service makes it possible to host sensitive workloads with node-to-node encryption by using Transport Layer Security (TLS) for all communications between instances in a cluster.Using node-to-node encryption ensures that any data you send to your Amazon Elasticsearch Service domain over HTTPS, remains encrypted in-flight while it is being distributed and replicated between the nodes.
Benchmarks
- PCI-DSS V3.2 3
- FEDRAMP (MODERATE) SC-7, SC-8, SC-8(1)
🎉 Fixed by commit e468d88 - Auto Format
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_ELASTICSEARCH_5 Fixed /main.tf module.elasticsearch.aws_elasticsearch_domain.default
|
/test all |
|
/test all |
goruha
approved these changes
Feb 23, 2023
|
@bgottlob LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
var.create_security_grouptofalsevar.security_groupswhy
var.security_groupsto be a list of security groups to be directly attached to the ElasticSearch domainreferences