Feature/9 check dogu health #10
Conversation
also: - refactor events - test dogu health checks - fix failing tests - move unhealthy logic to dogu installation
* Conflicts: * go.sum * pkg/domain/stateDiff.go
| case domain.StatusPhaseDogusUnhealthy: | ||
| return nil |
There was a problem hiding this comment.
Do we want that the blueprint retry if dogus are unhealthy? The problem could be that the previously determined state diff could be outdated then.
I think we should have a look at this again when the operator can install dogus, so that we have more experience, which states are really helpful and which states we could combine to a single one. This way we can refactor that in its completeness if necessary.
| func mustParseVersion(raw string) core.Version { | ||
| version, err := core.ParseVersion(raw) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| return version | ||
| } |
There was a problem hiding this comment.
Previously i simply created vars with parsed version numbers outside of the tests. The version-structs have a field for the raw string, so you can use the version struct even if you need to provide a string-typed version.
There was a problem hiding this comment.
Should I change it or is it ok like this?
Co-authored-by: Alexander Dammeier <alexander.dammeier@cloudogu.com>
|
Some tests fail after the refactoring. When they are fixed, we can merge :) |
Co-authored-by: Alexander Dammeier <alexander.dammeier@cloudogu.com>
Resolves #9