Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to cf_exporter to v1.0.0 and migrate job to bpm #457

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

psycofdj
Copy link
Contributor

@psycofdj psycofdj commented Mar 8, 2023

The PR bump cf-exporter from v0.10.1 to v1.0.0 which include:

  • use of CF v3 API only instead of v2
  • performance upgrade with better querying strategy
  • internal dependency bumping and CVE fixing

The PR also migrates from oldish start/stop run script to bpm. Exporter configuration is now generated in /var/vcap/jobs/cf_exporter/config/bpm.yml in a much more readable way:

---
processes:
- name: cf_exporter
  executable: "/var/vcap/packages/cf_exporter/bin/cf_exporter"
  env:
    CF_EXPORTER_WEB_LISTEN_ADDRESS: ":9193"
    CF_EXPORTER_CF_CLIENT_ID: cf_exporter
    CF_EXPORTER_CF_CLIENT_SECRET: secret
    CF_EXPORTER_CF_DEPLOYMENT_NAME: cf
    CF_EXPORTER_METRICS_ENVIRONMENT: myenv
  args:
  - "--log.level"
  - info
  - "--log.stream"
  - stderr
  - "--cf.api_url"
  - https://api.my.domain

@benjaminguttmann-avtq: new blob as already been uploaded

@psycofdj psycofdj changed the title bump to cf_exporter v1.0.0 and migrate job to bpm bump to cf_exporter to v1.0.0 and migrate job to bpm Mar 8, 2023
@benjaminguttmann-avtq
Copy link
Contributor

@psycofdj what about this PR => #445 is that still needed?

@psycofdj
Copy link
Contributor Author

psycofdj commented Mar 9, 2023

no, I forgot that the PR was already open 😅
#445 should be closed in favor to this one

@benjaminguttmann-avtq
Copy link
Contributor

@psycofdj

what about the following changes that were included in the other PR

cf_exporter.cf.api_v3_enabled: removed. Latest cf_exporter only use v3 API endpoints
cf_exporter.events.query: removed. When events are enabled, latest cf_exporter always query events of the last 10 minutes with 5k elements per page
cf_exporter.log_format: replaced by spec cf_exporter.log_stream and cf_exporter.log_json
cf_exporter.log_level: defaults to error instead of info
Operator changes

ops-file manifests/operators/enable-cf-api-v3.yml has been removed

are they still necessary ?

@psycofdj
Copy link
Contributor Author

psycofdj commented Mar 9, 2023

yes those changes are still included (they are the consequence of the new release of cf_exporter)
I forgot to delete deprecated ops-file manifests/operators/enable-cf-api-v3.yml which I will correct in the next commit

@benjaminguttmann-avtq
Copy link
Contributor

@psycofdj is the ops file removed :D Asking because I still cannot see that it is part of the PR to remove it

@psycofdj
Copy link
Contributor Author

you are right, missed the git add, I forced push an empty commit...
now we're good

@benjaminguttmann-avtq
Copy link
Contributor

thx @psycofdj for submitting this

@benjaminguttmann-avtq benjaminguttmann-avtq merged commit 9a2d340 into master Mar 13, 2023
@benjaminguttmann-avtq benjaminguttmann-avtq deleted the bump-cf-exporter branch March 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants