Fix CF Dashboard Issues #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold on a little bit. I think I was overly aggressive in the |
|
The issue has been fixed and tested. The "sed" issue was more a style than functional, since it was backward compatible. Thanks |
|
Thanks @ywei2017! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one time (not sure when), many of the CF dashboards no longer show any data (if they ever did). After investigation, I found it was due to the bosh_deployment name being "cf", instead of "cf-[0-9a-f]*". I updated the json files to fix the issue, and also backward compatible. The following is a list of issues and the result with the fix.
Apps:Latency (no data) [fixed]
Apps: Requests (no data) [fixed]
Apps: System (incomplete data) [fixed]
CF:Organization Memory Quotas (no data for "Organization's Memory Quota Consumption") [fixed]
CF:Route Emitter (no data) [fixed]
CF:Summary (no data for "Users") [fixed]
Component Metrics (no data) [improved]
Also fixed the CF:App:Requests dashboard error when multiple firehose exporters are configured.
Thanks
Yansheng