Convert exporter credentials to envvars, round 2 #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #357
Apologies I've taken a weeks longer than I expected to finish this.
It turns out there's only a handful more jobs which pass creds via CLI rather than
envvars
or config files-- and most aren't using creds directly at all. I've swapped those out, with the exception of themongodb_exporter
which doesn't appear to support passing creds via envvar, so ¯_(ツ)_/¯ no worriesPlease let me know if there's anything you'd like changed, etc.; I've got nice and relaxing time now while over break 👌thanks again
bosh_exporterdone in first PRcollectd_exporterN/Aconsul_exporterN/Aelasticsearch_exporterN/Afirehose_exporterdone in first PRgraphite_exporterN/Ahaproxy_exporterN/Ainfluxdb_exporterN/Akube-state-metrics exporterN/Amemcached exporterN/Amongodb_exporterdoesn't appear as though the mongodb exporter supports being passed creds via env?mysqld_exporterN/Anats_exporterN/Apostgres_exporterN/Arabbitmq_exporterN/Astackdriver+exporterN/Astatsd_exporterN/Avault_exporterN/A