Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert exporter credentials to envvars, round 2 #367

Merged
merged 4 commits into from
Jan 2, 2020
Merged

Convert exporter credentials to envvars, round 2 #367

merged 4 commits into from
Jan 2, 2020

Conversation

aegershman
Copy link
Contributor

@aegershman aegershman commented Dec 23, 2019

Continuation of #357

Apologies I've taken a weeks longer than I expected to finish this.

It turns out there's only a handful more jobs which pass creds via CLI rather than envvars or config files-- and most aren't using creds directly at all. I've swapped those out, with the exception of the mongodb_exporter which doesn't appear to support passing creds via envvar, so ¯_(ツ)_/¯ no worries

Please let me know if there's anything you'd like changed, etc.; I've got nice and relaxing time now while over break 👌thanks again

@aegershman aegershman marked this pull request as ready for review December 23, 2019 19:48
@frodenas frodenas merged commit 0fd52fb into cloudfoundry:master Jan 2, 2020
@frodenas
Copy link
Contributor

frodenas commented Jan 2, 2020

Thanks @aegershman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants