Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf_exporter: replace CLI args with ENV args #354

Merged
merged 2 commits into from
Nov 19, 2019
Merged

cf_exporter: replace CLI args with ENV args #354

merged 2 commits into from
Nov 19, 2019

Conversation

aegershman
Copy link
Contributor

@aegershman aegershman commented Nov 18, 2019

In order to prevent credentials passed to cf_exporter being visible in the VM's process table, this swaps out passing CLI args to cf_exporter in favor of leveraging exporting the equivalent env args

This would be the first of a few commits/PRs to update other exporters, e.g. firehose-exporter, bosh-exporter, etc.

Open questions/comments:

  • Should only credentials be swapped out to leverage env vars? E.g., allow for non-credential args to be passed via CLI so they're still visible in ps aux? Reason for not doing this is to maintain consistency.
  • Is current spacing acceptable? Or should it have no newlines inbetween?

@frodenas
Copy link
Contributor

@aegershman I don't think we need to switch all flags to envvars, just the ones that are sensitive, like client id and secret.

@aegershman
Copy link
Contributor Author

fixed 👍 in general I tend to leave username/client-id in plaintext, though would you all prefer they be moved to envvars as well? It's no problem either way.

@aegershman aegershman marked this pull request as ready for review November 19, 2019 15:01
@frodenas frodenas merged commit 5c7185c into cloudfoundry:master Nov 19, 2019
@frodenas
Copy link
Contributor

Thanks @aegershman

@aegershman aegershman deleted the cf-exporter-env-vars branch November 20, 2019 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants