cf_exporter: replace CLI args with ENV args #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent credentials passed to
cf_exporter
being visible in the VM's process table, this swaps out passing CLI args tocf_exporter
in favor of leveraging exporting the equivalent env argsThis would be the first of a few commits/PRs to update other exporters, e.g.
firehose-exporter
,bosh-exporter
, etc.Open questions/comments:
ps aux
? Reason for not doing this is to maintain consistency.